feat odbc: make driver production-ready - #1309
Open
V0S7ER wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #218.
This is a follow-up to #1161 that completes the remaining ODBC production-readiness work and addresses the maintainer feedback from that review.
What changed
ClusterandTransactionusing ODBC?placeholders,SQLPrepare,SQLNumParams,SQLBindParameter, andSQLExecute. The public API supports booleans, integer and floating-point types, strings, enums, optionals, and null values while keeping bound storage alive for the entire execution.CommandControlas public API, merged explicit/default/inherited deadlines, removed publicengine::Deadlineoverloads, and made network deadlines cover connection acquisition, connect, begin, and blocking statement execution.OperationInterruptedand accounted as a timeout.Cluster, with serialized topology replacement, unchanged-DSN suppression, safe pool/connection lifetime, and restoration of per-pool static settings when a dynamic override disappears.StrIcaseEqual,utils::text::ToUpper, designated initializers, and safe atomic ordering).User impact
ODBC users can pass query parameters separately from SQL text instead of formatting them into a query, configure operation timeouts through the same command-control model as other userver database drivers, reload DSNs through secdist, and rely on documented schemas and metrics.
Validation
userver-odbcand both functional services built successfullyclang-format --dry-run --Werror,git diff --check, JSON validation, and Python syntax checks passed