fix(firecracker): intercept SIGTERM and SIGINT to terminate VMM process immediately - #870
Open
Nachiket-Roy wants to merge 1 commit into
Open
fix(firecracker): intercept SIGTERM and SIGINT to terminate VMM process immediately#870Nachiket-Roy wants to merge 1 commit into
Nachiket-Roy wants to merge 1 commit into
Conversation
…ss immediately Firecracker does not handle SIGTERM/SIGINT, causing the signals to be ignored and leaving the VMM process running. When containerd/kubelet sends SIGTERM during container stop, the process stays alive for the entire 30-second grace period until containerd finally escalates to SIGKILL. We now intercept SIGTERM and SIGINT in Firecracker's Signal method and redirect them to Stop(), which terminates the VMM process immediately. This makes Firecracker container deletion instant (less than a second) rather than blocking for 30 seconds on every stop/delete cycle. Also added Nachiket Roy to the contributors list. Fixes urunc-dev#789 Signed-off-by: Nachiket Roy <nachiket.roy.2@gmail.com>
✅ Deploy Preview for urunc canceled.
|
Nachiket-Roy
marked this pull request as ready for review
July 31, 2026 13:17
Author
|
cc : @cmainas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Intercepts
SIGTERMandSIGINTsignals in the Firecracker hypervisor driver'sSignalmethod and redirects them toStop(pid). Since Firecracker ignores SIGTERM, this avoids waiting for the 30-second containerd grace period and makes container stops/deletions instant.Related issues
How was this tested?
go test ./pkg/...(all passed).nginx-uruncdeployment to 5 replicas, and deleted them. All pods stopped and were destroyed instantly (in0.816stotal) instead of blocking for 30 seconds.LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).