refactor: replace string concatenation in monitor CLI option construc… - #858
Open
singhshresth26 wants to merge 1 commit into
Open
refactor: replace string concatenation in monitor CLI option construc…#858singhshresth26 wants to merge 1 commit into
singhshresth26 wants to merge 1 commit into
Conversation
✅ Deploy Preview for urunc canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the monitor/hypervisor command line arguments construction to use string slices directly instead of inefficient string concatenation.
Previously, monitors (such as HVT, SPT, QEMU, Firecracker, and Cloud Hypervisor) built their CLI options as a single space-separated string using
cli += " option"and split it into a string slice at the end usingstrings.Split. This is inefficient because strings are immutable in Go, leading to unnecessary memory allocations, and the split operation adds overhead.This PR:
Unikernelinterface methodMonitorNetClito return[]stringinstead ofstring.MonitorBlockArgs.ExactArgsandMonitorCliArgs.OtherArgsto use[]stringinstead ofstring.Related issues
How was this tested?
Compiled the packages and verified that unit tests build successfully targeting Linux:
go build ./pkg/unikontainers/...- Passed successfully.go test -c ./pkg/unikontainers/...- Passed successfully.Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).