unikernels/linux: remove always-true conditional in firecracker block#764
Open
BRGOVIND wants to merge 1 commit into
Open
unikernels/linux: remove always-true conditional in firecracker block#764BRGOVIND wants to merge 1 commit into
BRGOVIND wants to merge 1 commit into
Conversation
Inside MonitorBlockCli(), the firecracker switch case already guarantees l.Monitor == firecracker, so the inner if-check is redundant. Remove it and assign the FC prefix directly. Signed-off-by: B R GOVIND <brgovind2005@gmail.com>
✅ Deploy Preview for urunc canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the redundant conditional inside MonitorBlockCli() in
pkg/unikontainers/unikernels/linux.go.
What
The case "firecracker": arm of the switch already guarantees that
l.Monitor == "firecracker" is true. The inner if l.Monitor == "firecracker"
check can therefore never evaluate to false, making it dead code.
Before:
After:
Testing
Existing unit tests cover this path. No behaviour change — the "FC" prefix was
always applied; this just removes the dead branch.
Closes #747