Дубровин Алексей#13
Open
Griboedoff wants to merge 3 commits intourfu-2017:masterfrom
Open
Conversation
|
🍏 Пройден линтинг и базовые тесты |
|
🍏 Пройден линтинг и базовые тесты |
evgenymarkov
suggested changes
Apr 16, 2018
evgenymarkov
left a comment
evgenymarkov
left a comment
There was a problem hiding this comment.
В целом всё ок, чуть-чуть доработать
| "spec-char-escape": true, | ||
| "tag-bans": [ | ||
| "b", | ||
| "i", |
There was a problem hiding this comment.
???
Лучше не использовать <i> если ты просто хочешь написать что-то курсивом. Для этого либо примени стили, либо тэг <em>.
| </label> | ||
| <label for="date" class="order__row"> | ||
| <span class="order__row-title">Дата</span> | ||
| <input type="date" class="order__input" id="date"> |
There was a problem hiding this comment.
type="date" поддерживается очень ограниченно
Чинить не призываю, но стоит иметь в виду.
| searchIcon.classList.remove('fa-search'); | ||
| }; | ||
|
|
||
| searchInput.onblur = () => { |
There was a problem hiding this comment.
Нужно дополнительно включать фокус на строку поиска после нажатия на кнопку
| searchIcon.classList.add('fa-search'); | ||
| } | ||
| }; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.