fix: allow DefaultCommand to handle its own flags

command_parse.go

@@ -199,13 +199,23 @@ func (cmd *Command) parseFlags(args Args) (Args, error) {
 				posArgs = append(posArgs, rargs...)
 				return &stringSliceArgs{posArgs}, nil
 			}
+			// When DefaultCommand is set, pass unknown flags through as positional args
+			// so the default command can handle them (fixes #2249)
+			if cmd.DefaultCommand != "" {
+				posArgs = append(posArgs, rargs...)
+				return &stringSliceArgs{posArgs}, nil
+			}
 			return &stringSliceArgs{posArgs}, fmt.Errorf("%s%s", providedButNotDefinedErrMsg, flagName)
 		}
 
 		// try to split the flags
 		for index, c := range flagName {
 			tracef("processing flag (fName=%[1]q)", string(c))
 			if sf := cmd.lookupFlag(string(c)); sf == nil {
+				if index == 0 && cmd.DefaultCommand != "" {
+					posArgs = append(posArgs, rargs...)
+					return &stringSliceArgs{posArgs}, nil
+				}
 				return &stringSliceArgs{posArgs}, fmt.Errorf("%s%s", providedButNotDefinedErrMsg, flagName)
 			} else if fb, ok := sf.(boolFlag); ok && fb.IsBoolFlag() {
 				fv := flagVal

command_test.go

@@ -5724,3 +5724,102 @@ func TestFlagEqualsEmptyValue(t *testing.T) {
 		assert.Equal(t, []string{"positional"}, args)
 	})
 }
+
+func TestDefaultCommandWithSubcommandFlags(t *testing.T) {
+	// Regression test for https://github.com/urfave/cli/issues/2249
+	// When DefaultCommand is set, flags defined on the default subcommand
+	// should work even when the subcommand name is omitted.
+	actionExecuted := false
+	cmd := &Command{
+		DefaultCommand: "run1",
+		Commands: []*Command{
+			{
+				Name:  "run1",
+				Usage: "run the main application",
+				Action: func(ctx context.Context, cmd *Command) error {
+					actionExecuted = true
+					return nil
+				},
+				Flags: []Flag{
+					&StringFlag{
+						Name:     "foo",
+						Required: true,
+					},
+				},
+			},
+			{
+				Name: "run2",
+				Action: func(ctx context.Context, cmd *Command) error {
+					return nil
+				},
+				Flags: []Flag{
+					&StringFlag{
+						Name:     "value",
+						Required: true,
+					},
+				},
+			},
+		},
+	}
+
+	// Using flag without subcommand name should route to default command
+	err := cmd.Run(buildTestContext(t), []string{"c", "--foo", "bar"})
+	assert.NoError(t, err)
+	assert.True(t, actionExecuted, "expected run1 action to be executed")
+}
+
+func TestDefaultCommandWithShortFlag(t *testing.T) {
+	// Covers the short-flag splitting path in parseFlags when DefaultCommand is set
+	cmd := &Command{
+		DefaultCommand: "run",
+		Commands: []*Command{
+			{
+				Name:  "run",
+				Usage: "run the app",
+				Action: func(ctx context.Context, cmd *Command) error {
+					if cmd.String("foo") != "baz" {
+						return fmt.Errorf("expected foo=baz, got %s", cmd.String("foo"))
+					}
+					return nil
+				},
+				Flags: []Flag{
+					&StringFlag{
+						Name:    "foo",
+						Aliases: []string{"f"},
+					},
+				},
+			},
+		},
+	}
+
+	err := cmd.Run(buildTestContext(t), []string{"c", "-f", "baz"})
+	assert.NoError(t, err)
+}
+
+func TestDefaultCommandWithShortFlagHandling(t *testing.T) {
+	// Covers the shortOptionHandling for-loop path when DefaultCommand is set
+	cmd := &Command{
+		UseShortOptionHandling: true,
+		DefaultCommand:         "run",
+		Commands: []*Command{
+			{
+				Name:  "run",
+				Usage: "run the app",
+				Action: func(ctx context.Context, cmd *Command) error {
+					if cmd.String("foo") != "baz" {
+						return fmt.Errorf("expected foo=baz, got %s", cmd.String("foo"))
+					}
+					return nil
+				},
+				Flags: []Flag{
+					&StringFlag{
+						Name:    "foo",
+						Aliases: []string{"f"},
+					},
+				},
+			},
+		},
+	}
+	err := cmd.Run(buildTestContext(t), []string{"c", "-f", "baz"})
+	assert.NoError(t, err)
+}