Fix 2257 - Remove incorrect flag check

[MohitPanchariya]

What type of PR is this?

(REQUIRED)

• bug

What this PR does / why we need it:

(REQUIRED)

Current Behavior

• If the argument passed with a command isn't a sub command, there are two checks performed - check if the command has a default command, and check if the argument passed is a flag.

• In the case that the default command doesn't exist, and the argument passed is the name of a flag, the sub command resolves to nil, which it was previously as well. Implying the check for the flag name doesn't have affect the sub command resolution.

• Since a default command doesn't exist, the cmd.parsedArgs list ends up with an empty argument as its zeroth element.

Changed Behavior

• This PR removes the flag name check since it doesn't have an effect on the sub command resolution.

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #2257

Testing

(fill-in or delete this section)

Tested the changes locally with the following program

package main

import (
	"context"
	"fmt"
	"os"

	"github.com/urfave/cli/v3"
)

func main() {
	topCommand := cli.Command{
		Name:  "topCommand",
		Usage: "topCommand usage",
		Flags: []cli.Flag{
			&cli.StringFlag{
				Name: "flag1",
			},
		},
		Action: func(ctx context.Context, c *cli.Command) error {
			fmt.Printf("%#v\n", c.Args())
			return nil
		},
	}
	subCommand1 := cli.Command{
		Name:  "subCommand1",
		Usage: "subCommand1 description",
		Action: func(ctx context.Context, c *cli.Command) error {
			fmt.Println("I am subCommand1")
			return nil
		},
	}
	subCommand2 := cli.Command{
		Name:  "subCommand2",
		Usage: "subCommand2 description",
		Action: func(ctx context.Context, c *cli.Command) error {
			fmt.Println("I am subCommand2")
			return nil
		},
	}

	topCommand.Commands = append(topCommand.Commands, &subCommand1, &subCommand2)
	topCommand.Run(context.Background(), os.Args)
}

Current state (observe the empty string in the arguments list)

./main --flag1 arg1 flag1
&cli.stringSliceArgs{v:[]string{"", "flag1"}}

With the change,

./main --flag1 arg1 flag1
&cli.stringSliceArgs{v:[]string{"flag1"}}

Release Notes

(REQUIRED)

NONE

[yassinebenaid]

@MohitPanchariya The Release Notes paragraph cannot be empty. Either fill it with a summary of your change (if it's user facing and worth documentation). Otherwise put NONE.

from template:

If this PR makes user facing changes, please describe them here. This
description will be copied into the release notes/changelog, whenever the
next version is released. Keep this section short, and focus on high level
changes.
Put your text between the block. To omit notes, use NONE within the block.

[dearchap]

@MohitPanchariya Can you add a test case with the same code as you posted above ? That would ensure that any changes in the future wont regress this fix.

[MohitPanchariya]

@dearchap Just saw the comments today because I kept wondering why the PR wasn't reviewed yet and decided to take a look. I likely missed the mail. I will try to address the comments over the weekend.

[MohitPanchariya]

@dearchap Added a test case.

@yassinebenaid Since its not a change in the expected behavior, or interface, I put NONE in the release notes.