QSTH-937: Upgrade the dependencies and pin versions#13
Open
mehmettokgoz wants to merge 4 commits intomasterfrom
Open
QSTH-937: Upgrade the dependencies and pin versions#13mehmettokgoz wants to merge 4 commits intomasterfrom
mehmettokgoz wants to merge 4 commits intomasterfrom
Conversation
ytkimirti
reviewed
Apr 1, 2026
There was a problem hiding this comment.
node-fetch@3.3.2 is ESM-only, but this project compiles to CommonJS ("module": "commonjs" in tsconfig.json). The postinstall script runs node install.js, so this will fail at runtime with:
Error [ERR_REQUIRE_ESM]: require() of ES Module node-fetch not supported
node-fetch v3 is ESM-only which breaks the CJS build. Use Node's built-in fetch with Readable.fromWeb() instead.
CI overwrites the version from the git tag at release time, so the value in package.json is irrelevant.
install.js is a build artifact generated by tsc from install.ts.
ytkimirti
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.