fix(utilization): hide usage when array is stopped - #2734
fix(utilization): hide usage when array is stopped#2734Eli Bosley (elibosley) wants to merge 1 commit into
Conversation
🔧 PR Test Plugin AvailableA test plugin has been generated for this PR that includes the modified files. Version: 📥 Installation Instructions:Install via Unraid Web UI:
Alternative: Direct Download
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe change gates filesystem utilization output on the ChangesFilesystem utilization gating
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change hides utilization percentages only for stopped arrays while preserving started-array behavior and status text; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
A stopped array can report 100% utilization because the UI treats missing free-space data as zero; this hides usage percentages until the array is started.
Why This Exists
When the array stops, filesystem size can remain available while free-space metrics are absent. The existing fallback converts the missing value to zero, which makes the used-space formula render 100%. This appears in the navigation usage bar and pool filesystem rows.
Resolution
Require the array state to be Started before rendering utilization. Stopped arrays now show offline or filesystem status text, while started arrays keep the current usage display.
Reviewer Considerations
Behavior Changes
Stopped arrays no longer show a usage percentage in the navigation bar or filesystem rows. Started arrays behave as before.
Implementation Summary
Verification
Risk
Low; the change only suppresses usage rendering while the array is stopped and preserves the existing status output.
Linear
Related to OS-803: https://linear.app/lime-technology/issue/OS-803/733-stopped-array-shows-100percent-utilization
Related to OS-804: https://linear.app/lime-technology/issue/OS-804/740-stopped-array-shows-100percent-utilization
Summary by CodeRabbit
Bug Fixes
Tests