Skip to content

Comments

Feat: Display corrupted files in ZFS#2547

Merged
limetech merged 1 commit intounraid:masterfrom
Squidly271:patch-7
Feb 20, 2026
Merged

Feat: Display corrupted files in ZFS#2547
limetech merged 1 commit intounraid:masterfrom
Squidly271:patch-7

Conversation

@Squidly271
Copy link
Contributor

@Squidly271 Squidly271 commented Feb 20, 2026

Changes the output in pool status from

  pool: storage
 state: DEGRADED
status: One or more devices is currently being resilvered.  The pool will
	continue to function, possibly in a degraded state.
action: Wait for the resilver to complete.
  scan: resilver in progress since Thu Feb 19 18:24:38 2026
	68.8T / 104T scanned at 2.81G/s, 48.3T / 104T issued at 1.97G/s
	2.80T resilvered, 46.64% done, 07:58:49 to go
expand: expanded raidz2-0 copied 103T in 4 days 00:32:32, on Sat Feb 14 20:04:35 2026
config:

	NAME                        STATE     READ WRITE CKSUM
	storage                     DEGRADED     0     0     0
	  raidz2-0                  DEGRADED     0     0     0
	    /dev/sdt1               ONLINE       0     0     9  (resilvering)
	    /dev/sdu1               ONLINE       0     0    14  (resilvering)
	    replacing-2             DEGRADED     0     0    26
	      11687508470009778260  UNAVAIL      0     0     0  was /dev/sdv1/old
	      /dev/sdv1             ONLINE       0     0     0  (resilvering)
.
.
.


errors: 1 data errors, use '-v' for a list

To instead be

  pool: storage
 state: DEGRADED
status: One or more devices is currently being resilvered.  The pool will
	continue to function, possibly in a degraded state.
action: Wait for the resilver to complete.
  scan: resilver in progress since Thu Feb 19 18:24:38 2026
	68.8T / 104T scanned at 2.80G/s, 48.5T / 104T issued at 1.97G/s
	2.81T resilvered, 46.84% done, 07:56:50 to go
expand: expanded raidz2-0 copied 103T in 4 days 00:32:32, on Sat Feb 14 20:04:35 2026
config:

	NAME                        STATE     READ WRITE CKSUM
	storage                     DEGRADED     0     0     0
	  raidz2-0                  DEGRADED     0     0     0
	    /dev/sdt1               ONLINE       0     0     9  (resilvering)
	    /dev/sdu1               ONLINE       0     0    14  (resilvering)
	    replacing-2             DEGRADED     0     0    26
	      11687508470009778260  UNAVAIL      0     0     0  was /dev/sdv1/old
	      /dev/sdv1             ONLINE       0     0     0  (resilvering)
.
.
.


errors: Permanent errors have been detected in the following files:

        /mnt/storage/EBooks/Calibre Library/Nina Planck/Real Food_ What to Eat and Why (3620)/cover.jpg

There is no change if there are no files corrupted in display. If you delete the file, the list will be empty, but stopping and starting will clear the message

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced zpool status reporting to display more detailed information during storage pool maintenance operations (scrub, resilver, and expansion).

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 20, 2026

Walkthrough

The change adds the verbose flag (-v) to three zpool status command invocations while preserving the existing path flag (-P), affecting zfs-scrub, zfs-resilver, and zfs-expansion operations in the FileSystemStatus component.

Changes

Cohort / File(s) Summary
zpool Status Verbose Flag
emhttp/plugins/dynamix/include/FileSystemStatus.php
Added -v (verbose) flag to zpool status commands for three operations: zfs-scrub, zfs-resilver, and zfs-expansion, changing -P to -Pv to enable detailed output while preserving path behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 A verbose hop through filesystem halls,
Where zpool commands now answer all calls!
With -v flag dancing in three graceful lines,
More details bloom like clover vines,
Status reports shine with verbose delight! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Feat: Display corrupted files in ZFS' directly and accurately describes the main change: adding verbose output (-v flag) to zpool status commands to display corrupted files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.02.20.0626
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2547/webgui-pr-2547.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix/include/FileSystemStatus.php

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2547, or run:

plugin remove webgui-pr-2547

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@Squidly271 Squidly271 added the 7.3 label Feb 20, 2026
@limetech limetech merged commit c678e48 into unraid:master Feb 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants