fix(IP) parsing ip addr with peer information#2546
fix(IP) parsing ip addr with peer information#2546SimonFair wants to merge 2 commits intounraid:masterfrom
Conversation
🔧 PR Test Plugin AvailableA test plugin has been generated for this PR that includes the modified files. Version: 📥 Installation Instructions:Install via Unraid Web UI:
Alternative: Direct Download
|
|
No actionable comments were generated in the recent review. 🎉 WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@etc/rc.d/rc.library.source`:
- Line 60: The sed token that strips " peer ..." currently only matches IPv4 and
uses unescaped dots; update the sed fragment in the pipeline that contains "s/
peer ...//g" so it accepts either an IPv4 dotted-quad (with dots escaped) or an
IPv6 address (hex digits and colons) followed by "/<prefix>" — use the existing
extended regex mode (sed -r) and an alternation grouping to match either address
form before the "/[0-9]+" prefix length, and keep the rest of the pipeline (the
ip -br addr show ... | awk ... | sed ...) unchanged.
#2544 is the original PR for 7.2 this will only be fixed in 7.3
Summary by CodeRabbit