Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes documentation infrastructure improvements focused on fixing the send feedback functionality and adding browser compatibility for the SDK version badge modal. The changes include:
- Adding Safari/webkit compatibility for CSS backdrop-filter
- Adding security attributes to the "Edit this page" link
- Implementing a build process to ensure custom template files are properly copied
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| doc/templates/uno/styles/main.css.map | Regenerated CSS source map with webkit prefix addition |
| doc/templates/uno/styles/main.css | Minified CSS with -webkit-backdrop-filter prefix added for Safari compatibility |
| doc/templates/uno/styles/docfx.js | Minified JS with security attributes added to edit link |
| doc/templates/uno/component/affix.js | Source JS with target="_blank" and rel="noopener noreferrer" added to edit link (line 62) |
| doc/gulpfile.js | Build script enhanced to copy custom template files to _site directory after docfx build |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: closes #
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️