feat(wasmskia): Drag & drop support #22315
Open
+570
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform/wasm 🌐
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements drag and drop support for WebAssembly/Skia platforms by integrating browser's native drag and drop API with Uno's drag and drop framework.
Key Changes:
- Adds a finalizer to
DataPackageto trigger cleanup via theDestroyedevent when the object is garbage collected - Implements browser-side drag and drop handling in TypeScript to capture drag events and manage data transfer
- Creates C# interop layer to bridge browser events to Uno's
CoreDragDropManager
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Uno.UWP/ApplicationModel/DataTransfer/DataPackage.cs | Adds finalizer and Destroyed event for cleanup when DataPackage is collected |
| src/Uno.UI.Runtime.Skia.WebAssembly.Browser/ts/Runtime/BrowserDragAndDropExtension.ts | New TypeScript implementation handling browser drag/drop events and data retrieval |
| src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Extensions/BrowserDragDropExtension.cs | C# interop layer converting browser events to Uno drag/drop operations |
| src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Hosting/WebAssemblyBrowserHost.cs | Registers the drag/drop extension with the API extensibility system |
| src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Devices/Input/BrowserPointerInputSource.cs | Changes HtmlPointerButtonsState enum to internal for shared use |
src/Uno.UI.Runtime.Skia.WebAssembly.Browser/ts/Runtime/BrowserDragAndDropExtension.ts
Outdated
Show resolved
Hide resolved
src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Extensions/BrowserDragDropExtension.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Extensions/BrowserDragDropExtension.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI.Runtime.Skia.WebAssembly.Browser/ts/Runtime/BrowserDragDropExtension.ts
Show resolved
Hide resolved
src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Extensions/BrowserDragDropExtension.cs
Show resolved
Hide resolved
src/Uno.UI.Runtime.Skia.WebAssembly.Browser/ts/Runtime/BrowserDragAndDropExtension.ts
Outdated
Show resolved
Hide resolved
src/Uno.UI.Runtime.Skia.WebAssembly.Browser/ts/Runtime/BrowserDragAndDropExtension.ts
Outdated
Show resolved
Hide resolved
src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Extensions/BrowserDragDropExtension.cs
Outdated
Show resolved
Hide resolved
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22315/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22315/docs/index.html |
ajpinedam
reviewed
Jan 10, 2026
| { | ||
| if (pendingId == id) | ||
| { | ||
| _log.Error( |
Contributor
There was a problem hiding this comment.
Should you validate if LogLevel.Error is enabled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: closes https://github.com/unoplatform/kahua-private/issues/400
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️