-
Notifications
You must be signed in to change notification settings - Fork 839
Sophisticated font fallback #22240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ramezgerges
wants to merge
15
commits into
unoplatform:master
Choose a base branch
from
ramezgerges:sophisticated_font_fallback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sophisticated font fallback #22240
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9417a07
chore: invalidate when fallback font task is resolved
ramezgerges 6364e86
chore: minor fix and refactoring
ramezgerges 8625ec7
chore: initial attempt at font fallback service
ramezgerges dd21450
chore: IFontFallbackService
ramezgerges cd09e79
chore: fetching from github and more work
ramezgerges 60ba185
chore: avoid ContinueWith
ramezgerges ab9d0e1
chore: cjk handling
ramezgerges 0289a8e
chore: move win32 logic to Uno.WinUI and commit generated files
ramezgerges 903edc5
chore: add FontFallbackPreprocessor
ramezgerges 87dcb71
chore: add CI check for font fallback generation
ramezgerges 78263e6
chore: improved CJK font matching
ramezgerges 85c326e
chore: add license
ramezgerges 66ecbfb
test: add Check_FontFallback_Shaping2
ramezgerges 5775d75
chore: move AndroidSkiaFontFallbackService work off the UI thread
ramezgerges 276d8e9
chore: azure script mistake
ramezgerges File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| parameters: | ||
| vmImage: '$(linuxVMImage)' | ||
|
|
||
| stages: | ||
| - stage: FontFallback_Validation | ||
| displayName: Validate FontFallbackMaps | ||
| dependsOn: [] | ||
|
|
||
| jobs: | ||
| - job: Validate_FontFallback | ||
| displayName: Validate FontFallbackMaps.skia.cs | ||
| pool: | ||
| vmImage: ${{ parameters.vmImage }} | ||
|
|
||
| steps: | ||
| - checkout: self | ||
| clean: true | ||
| sparseCheckoutPatterns: | | ||
| src/FontFallbackPreprocessor/** | ||
| src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs | ||
| global.json | ||
| Directory.Build.props | ||
| Directory.Build.targets | ||
| src/Directory.Build.props | ||
| src/Directory.Build.targets | ||
|
|
||
| - bash: | | ||
| set -euo pipefail | ||
|
|
||
| echo "Regenerating FontFallbackMaps.skia.cs..." | ||
| dotnet run --project src/FontFallbackPreprocessor/FontFallbackPreprocessor.csproj -c Release -- --summary-only > src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs.new | ||
|
|
||
| if ! diff -u src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs.new; then | ||
| echo "Error: FontFallbackMaps.skia.cs is not up to date." | ||
| echo "Please run the following command locally and commit the changes:" | ||
| echo "dotnet run --project src/FontFallbackPreprocessor/FontFallbackPreprocessor.csproj -- --summary-only > src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs" | ||
| exit 1 | ||
| else | ||
| echo "FontFallbackMaps.skia.cs is up to date." | ||
| rm src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs.new | ||
| fi | ||
| displayName: Validate FontFallbackMaps.skia.cs |
14 changes: 14 additions & 0 deletions
14
src/FontFallbackPreprocessor/FontFallbackPreprocessor.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| ο»Ώ<Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net10.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="System.CommandLine" Version="2.0.0-beta4.22272.1" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The System.CommandLine package version 2.0.0-beta4.22272.1 is a pre-release beta version from 2022. Consider using a stable release version if available, as beta versions may have bugs or breaking changes. Check if a stable 2.0+ version has been released since this beta.