chore(FluentAssertions): Update provided Version to latest free and pin it there #1660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in it there By pinning the version, the user still has the active choice, to remove the Brackets if he might want to pay for newer versions, but those who may don't want to, but using GitHub actions and dependabot, will not run into licensing problems by accident. This results also in a better user experience
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the FluentAssertions package version from 6.12.0 to 7.2.0 and pins it to prevent automatic updates that could introduce licensing issues. The change addresses a dependency management concern where users could inadvertently upgrade to paid versions of FluentAssertions through automated dependency updates.
- Updated FluentAssertions version to the latest free (Apache 2.0) version
- Added version pinning using bracket notation to prevent automatic updates
- Improved user experience by preventing accidental licensing issues
Contributor
Author
|
@jeromelaban what about this? |
Contributor
Author
|
Not sure what is causing this to fail🤔 https://github.com/unoplatform/uno.templates/actions/runs/16380313603/job/46291634241#step:2:1 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #1625
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Updated the Version to the latest free (Apache2.0) version
pinning the version of this particular Package
By pinning that version, the user still has the active choice, to remove the Brackets, if he might want to pay for newer versions, but those who may don't want to, but using GitHub actions and dependabot, will not run into licensing problems by accident. This results also in a better user experience
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Maybe there should be added a note in the documentation thats informing the user about this, but kind of all testing documentation are in contribution section, which makes it not clearly visible for non-contributor users
Maybe that should get added in the templating docs, but those are not on this Repository => can not be included in this PR by that. maybe move the #1606 issue to the appropriate repo, which holds that docs and resolve it there?
Internal Issue (If applicable):