Fix conflicts to work with Newlib4.4 and pthread-embedded#24
Open
SalarSamani wants to merge 2 commits intounikraft:stagingfrom
Open
Fix conflicts to work with Newlib4.4 and pthread-embedded#24SalarSamani wants to merge 2 commits intounikraft:stagingfrom
SalarSamani wants to merge 2 commits intounikraft:stagingfrom
Conversation
craciunoiuc
reviewed
Aug 18, 2025
|
|
||
| # Preprocessing symbols | ||
| LIBPYTHON3_CORE_DEFINES-y += $(LIBPYTHON3_COMMON_DEFINES-y) -DPy_BUILD_CORE -DPy_BUILD_CORE_BUILTIN | ||
| LIBPYTHON3_CORE_DEFINES-y += $(LIBPYTHON3_COMMON_DEFINES-y) -DPy_BUILD_CORE -DPy_BUILD_CORE_BUILTIN -DWORKAROUND_PTHREAD_EMBEDDED |
Member
There was a problem hiding this comment.
I think this should be added only if the NEWLIB and PTHREAD symbols exist right?
Member
There was a problem hiding this comment.
+1 Use LIBPYTHON3_CORE_DEFINES-$(LIBPTHREAD_EMBEDDED)
StefanJum
requested changes
Aug 22, 2025
Member
StefanJum
left a comment
StefanJum
left a comment
There was a problem hiding this comment.
This goes for all PRs:
- Where the commits are small, like this, you should have everything in a single commit.
- Sign-off the commit (using
-s, with your name and email, same as the author name/email) - Use some descriptive commit message. You can check the
git logfor examples - Use commit messages with the right format, a bit more explicit. Again, you can check
git logfor that.
|
|
||
| # Preprocessing symbols | ||
| LIBPYTHON3_CORE_DEFINES-y += $(LIBPYTHON3_COMMON_DEFINES-y) -DPy_BUILD_CORE -DPy_BUILD_CORE_BUILTIN | ||
| LIBPYTHON3_CORE_DEFINES-y += $(LIBPYTHON3_COMMON_DEFINES-y) -DPy_BUILD_CORE -DPy_BUILD_CORE_BUILTIN -DWORKAROUND_PTHREAD_EMBEDDED |
Member
There was a problem hiding this comment.
+1 Use LIBPYTHON3_CORE_DEFINES-$(LIBPTHREAD_EMBEDDED)
This was referenced Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.