Skip to content

docs(pr-review): orchestrator split — ADR, PRD, and issues#27

Merged
orioltf merged 8 commits into
developfrom
feature/pr-review/orchestrator-split
May 11, 2026
Merged

docs(pr-review): orchestrator split — ADR, PRD, and issues#27
orioltf merged 8 commits into
developfrom
feature/pr-review/orchestrator-split

Conversation

@orioltf
Copy link
Copy Markdown
Member

@orioltf orioltf commented May 11, 2026

Summary

  • Adds ADR 0013 recording the decision to refactor review-pr.md into a thin orchestrator plus three focused agents (ADO Fetcher, Re-review Coordinator, ADO Writer)
  • Updates CONTEXT.md with the three operating modes (Pre-PR, First-review, Re-review) and orchestration agent terms
  • Publishes the PRD and 7 ready-for-agent implementation issues for the orchestrator split feature

Why

review-pr.md has grown to ~1000 lines, pushing average PR reviews past 100 K parent-context tokens. An emerging pre-PR mode request would worsen this. The split separates orchestration, ADO integration, and re-review state management into focused agents that only load when their mode is active.

Test plan

  • No code changes in this PR — docs and issue tracker only
  • All 7 implementation issues are ready-for-agent with agent briefs
  • pnpm format passes (Markdown only)

🤖 Generated with Claude Code

orioltf and others added 5 commits May 8, 2026 22:58
…split

Records the decision to refactor review-pr.md into a thin orchestrator
plus three focused agents (ado-fetcher, re-review-coordinator, ado-writer),
and defines the three operating modes and orchestration agent terms in
CONTEXT.md.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds the needs-triage PRD for refactoring review-pr.md into a thin
orchestrator plus ADO Fetcher, Re-review Coordinator, and ADO Writer
agents, covering the pre-PR mode, compact sub-agent output, and
deferred toolkit normalisation decisions.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds agent brief and updates status to ready-for-agent.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Breaks the orchestrator split PRD into 7 independently-grabbable
vertical slices: ADO Fetcher, ADO Writer, and Re-review Coordinator
agents (parallelizable), thin orchestrator refactor, pre-PR mode,
compact sub-agent output guidance, and version bump.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-agent

Adds agent briefs and updates status on all seven issues.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documents the decision and work breakdown for splitting the pr-review command into a thin orchestrator plus three focused agents, and introduces the three operating modes (Pre-PR / First-review / Re-review) in the plugin’s shared vocabulary.

Changes:

  • Adds ADR 0013 capturing the rationale and approach for the orchestrator split.
  • Updates apps/claude-code/pr-review/CONTEXT.md with new operating modes and orchestration agent definitions.
  • Publishes the feature PRD plus 7 ready-for-agent implementation issues for the split (including pre-PR mode and compact finding schema).

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
docs/issues/pr-review-orchestrator-split/PRD.md New PRD defining the orchestrator split feature and its requirements/test strategy.
docs/issues/pr-review-orchestrator-split/01-create-ado-fetcher-agent.md Implementation issue for the read-only ADO Fetcher agent.
docs/issues/pr-review-orchestrator-split/02-create-ado-writer-agent.md Implementation issue for the ADO Writer (write-back) agent.
docs/issues/pr-review-orchestrator-split/03-create-re-review-coordinator-agent.md Implementation issue for the Re-review Coordinator agent owning the state machine.
docs/issues/pr-review-orchestrator-split/04-refactor-orchestrator.md Implementation issue for refactoring review-pr.md into a thin orchestrator.
docs/issues/pr-review-orchestrator-split/05-add-pre-pr-mode.md Implementation issue for adding local-only Pre-PR mode.
docs/issues/pr-review-orchestrator-split/06-compact-subagent-output.md Implementation issue for enforcing compact structured findings from aspect agents.
docs/issues/pr-review-orchestrator-split/07-version-bump-and-release.md Implementation issue for version bump + changelog entry after feature delivery.
apps/claude-code/pr-review/docs/adr/0013-orchestrator-split-for-review-pr.md New ADR recording the architectural decision and consequences.
apps/claude-code/pr-review/CONTEXT.md Adds shared terminology for modes and the three orchestration agents.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/issues/pr-review-orchestrator-split/PRD.md
Comment thread docs/issues/pr-review-orchestrator-split/PRD.md Outdated
Comment thread docs/issues/pr-review-orchestrator-split/PRD.md Outdated
Comment thread docs/issues/pr-review-orchestrator-split/04-refactor-orchestrator.md Outdated
orioltf and others added 3 commits May 11, 2026 17:22
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
… issues

- Make prerequisite validation mode-aware in issue 04: Azure CLI and
  azure-devops extension are only required when a PR URL is provided;
  Pre-PR mode must not need ADO credentials
- Align field count in issue 06: schema has six fields (severity,
  filePath, startLine, endLine, title, body) but acceptance criteria
  incorrectly said "five required fields" — updated to "six"

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… docs

- CONTEXT.md: Re-review mode trigger now says "prior Bot Signature is
  found" instead of "prior Review Threads are detected" (the Bot
  Signature is the precise discriminator)
- CONTEXT.md + ADR 0013 + PRD: remove "delta summary" from Re-review
  Coordinator responsibilities — delta reply posting belongs to the ADO
  Writer, not the Re-review Coordinator
- ADR 0013: fix compact finding schema field name file → filePath to
  match all other documents
- ADR 0013: fix See also reference from docs/plans/ (empty) to the
  actual docs/issues/pr-review-orchestrator-split/PRD.md
- PRD: remove spurious ## Comments heading, place triage blockquote
  directly under ## Agent Brief per peer-file convention
- Issue 04: clarify ADO Fetcher bootstrapping sequence — orchestrator
  makes a lightweight thread-list call first for mode detection and
  prior-commit-SHA extraction, then calls ADO Fetcher with that SHA

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@orioltf orioltf merged commit e493db8 into develop May 11, 2026
4 checks passed
@orioltf orioltf deleted the feature/pr-review/orchestrator-split branch May 11, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants