fix: add non-free apt sources for nvidia-cuda-toolkit on Bookworm#2057
Open
harshmathurx wants to merge 2 commits into
Open
fix: add non-free apt sources for nvidia-cuda-toolkit on Bookworm#2057harshmathurx wants to merge 2 commits into
harshmathurx wants to merge 2 commits into
Conversation
The python:3.12-slim-bookworm base image only has main and non-free-firmware components enabled. nvidia-cuda-toolkit lives in non-free, which is not included by default in Debian Bookworm slim images. Add deb http://deb.debian.org/debian bookworm non-free to sources.list before the GPU install block so ENABLE_GPU=true builds don't fail with "Package has no installation candidate". Also fixes a stray trailing space after apt-get clean. Fixes unclecode#2020
Contributor
Author
|
@ntohidi gentle ping for review when you have a moment. I have retargeted this to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
python:3.12-slim-bookwormbase image only hasmainandnon-free-firmwarecomponents enabled.nvidia-cuda-toolkitlives innon-free, and some of its install-time dependencies resolve fromcontrib, so the GPU Docker build needs both components enabled before installing it.This PR adds
deb http://deb.debian.org/debian bookworm contrib non-freetosources.listbefore the GPU install block soENABLE_GPU=truebuilds don't fail with:Also fixes a stray trailing space after
apt-get clean \.Fixes #2020.
Validation:
main non-free-firmware+ this added source).apt-cache policy nvidia-cuda-toolkitfinds candidate11.8.89~11.8.0-5~deb12u1.apt-get install -s --no-install-recommends nvidia-cuda-toolkitresolves successfully withcontrib non-free; it fails withnon-freealone due missing dependencies.