Skip to content

Readded Stinson filter #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rchung95 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Readded Stinson filter #250

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
466788d
Readded Stinson filter
Oct 21, 2016
17b262f
Changed settings to reflect it better
Nov 2, 2016
95f7382
Added the changes requested.
Nov 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions site/filters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@
},
{
"name": "Stinson",
"is_done": false,
"is_done": true,
"usage": "stinson"
},
{
Expand Down Expand Up @@ -203,4 +203,4 @@
],

"images": ["atx", "bike", "cacti", "lakegeneva", "tahoe"]
}
}
3 changes: 2 additions & 1 deletion source/scss/cssgram.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
@import 'willow';
@import 'rise';
@import 'slumber';
@import 'stinson';
@import 'brannan';
@import 'valencia';
@import 'kelvin';
@import 'kelvin';
41 changes: 41 additions & 0 deletions source/scss/stinson.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
/*
*
* Stinson
*
*/
@import 'shared';

// mixin to extend stinson filter
// @mixin stinson
// @param $filters... {filter} - Zero to many css filters to be added
// @example
// img {
// @include stinson;
// }
// or
// img {
// @include stinson(blur(2px));
// }
// or
// img {
// @include stinson(blur(2px)) {
// /*...*/
// };
// }
@mixin stinson($filters...) {
@include filter-base;
filter: brightness(1.25) contrast(0.8) saturate(0.95) grayscale(0.05) sepia(0.05) $filters;
Copy link
Copy Markdown
Owner

@una una Nov 3, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I did some adjustments, what do you think of using filter: brightness(1.15) contrast(.8) saturate(.85) sepia(.1);

and altering the ::after pseudo element to be:

background: rgba(240, 149, 128, .2);
mix-blend-mode: soft-light;

Before:
screen shot 2016-11-02 at 11 05 04 pm

After -- I think it looks a little bit closer (tiny bit lighter and warmer):
screen shot 2016-11-02 at 11 05 37 pm


&::after {
background: rgb(235, 228, 222);
mix-blend-mode: multiply;
}

@content;
}

// stinson Instagram filter
%stinson,
.stinson {
@include stinson;
}