Fix Issue 56 -Allow force expiration to save timestamps without password hash#60
Open
wopsononock wants to merge 4 commits intostable-3_4from
Open
Fix Issue 56 -Allow force expiration to save timestamps without password hash#60wopsononock wants to merge 4 commits intostable-3_4from
wopsononock wants to merge 4 commits intostable-3_4from
Conversation
… and date only. Handle resulting null password fields when getting stored_passwords data.
Contributor
Author
|
Unintended amount of commits in here. Will rework. |
… while making sure existing stored_passwords tables have a nullable password field. Also bump the version
bdgregg
approved these changes
Feb 19, 2026
bdgregg
left a comment
bdgregg
left a comment
There was a problem hiding this comment.
Your changes seem to be pretty straight forward. Looks ok to me.
ctgraham
reviewed
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the administrator is not limiting password reuse, we don't save the current password hash to the stored_passwords table. If they are forcing expiration, we still need to save a password set timestamp for the username in question. Change the plugin to make a rule allowing null values on the password field when the plugin is installed or updated. When checking for reuse, make sure we can handle existing records with null password fields.