4400 remove hardcoded bc20m and tc0m - #4478
Open
chris-ashe wants to merge 8 commits into
Open
Conversation
…e parameters for improved flexibility
…SuperconductorModel
…SuperconductorModel
…field and temperature
… replacing them with dynamic properties from SuperconductorModel
…them with dynamic properties from SuperconductorModel
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4478 +/- ##
==========================================
+ Coverage 48.64% 48.69% +0.04%
==========================================
Files 151 151
Lines 29704 29737 +33
==========================================
+ Hits 14449 14479 +30
- Misses 15255 15258 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clmould
requested changes
Jul 28, 2026
| BI2212 = ( | ||
| 2, | ||
| SuperconductorMaterial.BI2212, | ||
| None, |
Collaborator
There was a problem hiding this comment.
Could any with None have a brief comment to explain why?
| @@ -129,8 +128,8 @@ def jcrit_from_material( | |||
| j_crit_cable = j_crit_cable_from_fraction(j_crit_sc, f_tf_conductor_copper, f_he) | |||
|
|
|||
| elif i_tf_sc_mat == 7: # Durham Ginzburg-Landau Nb-Ti parameterisation | |||
Collaborator
There was a problem hiding this comment.
Should these if/elif statements be using the SuperconductorModel instead of the corresponding integer?
(I can make a separate issue for papercuts if out of scope of this pr)
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
clmould
requested changes
Jul 28, 2026
| CROCO_REBCO = ( | ||
| 6, | ||
| SuperconductorMaterial.REBCO, | ||
| None, |
Collaborator
There was a problem hiding this comment.
Could this have a comment here too plz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
I confirm that I have completed the following checks: