Skip to content

Introduce TFWPIntegerTurnType enum and update references in TF coil m… - #4470

Open
chris-ashe wants to merge 1 commit into
mainfrom
add_tf_int_turns_enum
Open

Introduce TFWPIntegerTurnType enum and update references in TF coil m…#4470
chris-ashe wants to merge 1 commit into
mainfrom
add_tf_int_turns_enum

Conversation

@chris-ashe

Copy link
Copy Markdown
Collaborator

…odels and tests

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe
chris-ashe requested a review from a team as a code owner July 25, 2026 22:36
@chris-ashe chris-ashe added TF Coil Toroidal field coil Refactor labels Jul 25, 2026
@chris-ashe
chris-ashe force-pushed the add_tf_int_turns_enum branch from c792089 to 2b976dc Compare July 25, 2026 23:03
@codecov-commenter

codecov-commenter commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.84211% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.38%. Comparing base (808481e) to head (2b976dc).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
process/core/io/plot/summary.py 5.55% 17 Missing ⚠️
process/models/tfcoil/superconducting.py 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4470      +/-   ##
==========================================
+ Coverage   48.64%   49.38%   +0.73%     
==========================================
  Files         151      151              
  Lines       29704    31528    +1824     
==========================================
+ Hits        14449    15569    +1120     
- Misses      15255    15959     +704     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn self-assigned this Jul 28, 2026
Comment thread process/models/tfcoil/base.py
@chris-ashe
chris-ashe requested a review from timothy-nunn July 28, 2026 08:10
@timothy-nunn

Copy link
Copy Markdown
Collaborator

Sorry my suggestion has broken things :D just undo it because its within a Numba block

@chris-ashe
chris-ashe force-pushed the add_tf_int_turns_enum branch from de2442d to 2b976dc Compare July 28, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor TF Coil Toroidal field coil

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants