Add AvailabilityModel enum for plant availability models - #4468
Add AvailabilityModel enum for plant availability models#4468chris-ashe wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4468 +/- ##
==========================================
+ Coverage 48.64% 48.66% +0.01%
==========================================
Files 151 151
Lines 29704 29721 +17
==========================================
+ Hits 14449 14463 +14
- Misses 15255 15258 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
501a28a to
e720c8e
Compare
| case 20: | ||
| self.data.constraints.t_burn_min = swp[iscn - 1] | ||
| case 22: | ||
| if self.data.costs.i_plant_availability == 1: |
There was a problem hiding this comment.
Is there a reason this only applies to i_plant_availability == 1? I find it more likely that this should be checking AvailabilityModel(self.data.costs.i_plant_availability) != AvailabilityModel.INPUT... I.e. don't scan if f_t_plant_available is not being input because the scanned value will get overwritten by the model
| if ( | ||
| AvailabilityModel(data.costs.i_plant_availability) | ||
| != AvailabilityModel.WARD_TAYLOR | ||
| ): |
There was a problem hiding this comment.
Similar question, is this correct anymore. Shouldn't you be able to optimise if using model 1, 2, or 3?


Description
Checklist
I confirm that I have completed the following checks: