Skip to content

Constraint vars dataclass#4250

Merged
timothy-nunn merged 2 commits into
mainfrom
Constraints-Dataclass
May 14, 2026
Merged

Constraint vars dataclass#4250
timothy-nunn merged 2 commits into
mainfrom
Constraints-Dataclass

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented May 13, 2026

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould mentioned this pull request May 13, 2026
59 tasks
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 13, 2026

Codecov Report

❌ Patch coverage is 90.51724% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.94%. Comparing base (d7449c3) to head (d563d7e).

Files with missing lines Patch % Lines
process/core/scan.py 0.00% 8 Missing ⚠️
process/models/fw.py 0.00% 1 Missing ⚠️
process/models/stellarator/coils/calculate.py 0.00% 1 Missing ⚠️
process/models/stellarator/stellarator.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4250      +/-   ##
==========================================
- Coverage   50.99%   50.94%   -0.05%     
==========================================
  Files         151      151              
  Lines       29772    29744      -28     
==========================================
- Hits        15181    15153      -28     
  Misses      14591    14591              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould force-pushed the Constraints-Dataclass branch from 22961e9 to 2b8b809 Compare May 13, 2026 16:29
@clmould clmould marked this pull request as ready for review May 13, 2026 16:32
@clmould clmould requested a review from a team as a code owner May 13, 2026 16:32
Comment thread tests/unit/models/tfcoil/test_sctfcoil.py Outdated
@clmould clmould requested a review from timothy-nunn May 14, 2026 09:00
@timothy-nunn timothy-nunn merged commit a72b599 into main May 14, 2026
10 of 11 checks passed
@timothy-nunn timothy-nunn deleted the Constraints-Dataclass branch May 14, 2026 09:40
@timothy-nunn timothy-nunn added the Data structure Issues related to the data structure label May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Data structure Issues related to the data structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants