Skip to content

fixed senbatsu infix; it now uses the root of triangular number formula - #4

Open
ExSlam wants to merge 33 commits into
ui3TD:mainfrom
ExSlam:fixes
Open

fixed senbatsu infix; it now uses the root of triangular number formula#4
ExSlam wants to merge 33 commits into
ui3TD:mainfrom
ExSlam:fixes

Conversation

@ExSlam

@ExSlam ExSlam commented Jan 20, 2026

Copy link
Copy Markdown

No description provided.

@ExSlam

ExSlam commented Jan 20, 2026

Copy link
Copy Markdown
Author

All fixes and updates to Unofficial Patch are done and complete. The majority of added lines of code are just to refactor the magic numbers into named variables and added comments for clarity. I also added a logger function that will write info and errors to the unity log which bepinex can log. I also added the following fixes to the game's bugs which weren't patched in the Unofficial Patch originally:

  1. GetSenbatsuParamValue(data_girls._paramType Type) ignores Type and always uses data_girls._paramType.cute, which breaks callers that request other params (e.g., the marketing PV formulas in singles.cs). Fix: patch this method to pass Type into SenbatsuCalcParam.

  2. vn_requirements.cs - in CheckGirl’s "variable" handling, formula.Substring(1) isn’t assigned back to formula, so !var checks effectively always return true. Fix: assign formula = formula.Substring(1) before calling IsVariable.

@ui3TD

ui3TD commented Jan 20, 2026

Copy link
Copy Markdown
Owner

Thank you! I'll review it this weekend

@ui3TD

ui3TD commented Feb 13, 2026

Copy link
Copy Markdown
Owner

Ah, sorry! Life stuff got in the way.

FastForward
- centralize speed calculation/apply logic and clamp/validate multiplier parsing
- add popup-aware suspend/restore hooks so custom super-fast speed does not break audition popup init
- clear pending restore when leaving fast state
- bump version to 1.2.1

Targeted Auditions
- harden ScrollRect setup with null checks and component reuse
- add portrait-load watchdog (Set/Reset/Close tracking + timeout fallback) to avoid recruitment popup deadlocks
- keep popup interactive after timeout and fill missing portraits from fallback sprite when available
- bump version to 2.0.2

Harmony Checker
- guard Mods button lookup against missing UI nodes to avoid menu-time exceptions

Unofficial Patch
- rework theater payout fix to use vanilla-written daily stat rows instead of pre-mutating Doing_Now
- keep day-off revenue at zero and split actual show-day revenue (plus first-day subs) safely among active girls
- add breakup null-safety around relationship/girl access before clearing partner-known flags
- replace fragile GetPartnerString transpiler with postfix string builder for underage partner visibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants