refactor: remove jsdom dependency from vitest config#96
Merged
Conversation
The jsdom environment was configured but none of the unit tests use DOM APIs — they all test pure logic (dependency graphs, content hashing, URL paths, entry path validation). Switch to the default node environment and remove the jsdom devDependency. Closes #88 https://claude.ai/code/session_01MXf6zdcermnEnEYtCNES6K
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsdomdevDependency and theenvironment: "jsdom"vitest config, switching to the defaultnodeenvironmentvitest.setup.tsfile and__tests__directoryAll 30 tests pass with the
nodeenvironment.Closes #88
Test plan
pnpm test:run— all 30 unit tests pass withnodeenvironmenthttps://claude.ai/code/session_01MXf6zdcermnEnEYtCNES6K