Skip to content

Fix Start auth server peer tracing#268

Open
zbeyens wants to merge 4 commits into
mainfrom
codex/start-auth-static-import
Open

Fix Start auth server peer tracing#268
zbeyens wants to merge 4 commits into
mainfrom
codex/start-auth-static-import

Conversation

@zbeyens
Copy link
Copy Markdown
Member

@zbeyens zbeyens commented May 21, 2026

  • Auto release

🐛 Fixes local package bug (no tracker issue)
🟢 95-100% confidence

Phase 🧪 Tests 🌐 Browser
Reproduced 🔴 bun test packages/kitcn/src/auth-start/index.test.ts --test-name-pattern 'statically traceable' ➖ N/A
Verified 🟢 targeted auth/start tests, package build, typecheck, lint, bun check ➖ N/A

✅ Outcome

  • kitcn/auth/start now statically imports @tanstack/react-start/server.
  • Declared @tanstack/react-start as optional peer + package dev dependency.
  • Added regression coverage for the traceable import.
  • Updated changeset and captured the solution note.
  • Fixture sync updated Expo package patch versions.

⚠️ Caveat

  • No browser surface changed.

🏗️ Design

  • Chosen seam: package entrypoint import graph.
  • Why not quick patch: app-level Nitro traceDeps would force every Start user to patch around kitcn.
  • Why not broader change: kitcn/auth/start is already the framework-specific surface; no API redesign needed.

🧪 Verified

  • bun test packages/kitcn/src/auth-start/index.test.ts --test-name-pattern 'statically traceable' fails before fix.
  • bun test packages/kitcn/src/auth-start/index.test.ts packages/kitcn/src/auth-start/index.retry.test.ts
  • bun --cwd packages/kitcn build
  • rg -n "@tanstack/react-start/server|import\\(" packages/kitcn/dist/auth/start/index.js packages/kitcn/src/auth-start/index.ts
  • bun lint:fix
  • bun typecheck
  • bun test packages/kitcn/src/package-intent.test.ts --test-name-pattern 'declares intent metadata'
  • GIT_TERMINAL_PROMPT=0 bun check

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 21, 2026

🦋 Changeset detected

Latest commit: 7f9a9f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
kitcn Patch
@kitcn/resend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
better-convex Ready Ready Preview, Comment May 21, 2026 8:47pm

Request Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 827b3e064f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f9a9f8af5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -1,4 +1,4 @@
import { convexBetterAuthReactStart } from 'kitcn/auth/start';
import { convexBetterAuthReactStart } from 'kitcn/auth/start/server';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add fixture path mapping for new start server subpath

Switching this fixture to kitcn/auth/start/server introduces an unresolved import in local fixture/scenario runs that rely on tsconfig path rewrites to source files: tooling/fixtures.ts only maps kitcn/auth/start (not the new /server subpath), so Vite/TS falls back to package exports and looks for packages/kitcn/dist/auth/start/server/index.js, which is absent in a fresh checkout unless packages/kitcn has been built first. This breaks scenario:prepare/fixture dev flows in clean environments; add a matching kitcn/auth/start/server mapping in fixture path generation.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant