Fix Start auth server peer tracing#268
Conversation
🦋 Changeset detectedLatest commit: 7f9a9f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 827b3e064f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f9a9f8af5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,4 +1,4 @@ | |||
| import { convexBetterAuthReactStart } from 'kitcn/auth/start'; | |||
| import { convexBetterAuthReactStart } from 'kitcn/auth/start/server'; | |||
There was a problem hiding this comment.
Add fixture path mapping for new start server subpath
Switching this fixture to kitcn/auth/start/server introduces an unresolved import in local fixture/scenario runs that rely on tsconfig path rewrites to source files: tooling/fixtures.ts only maps kitcn/auth/start (not the new /server subpath), so Vite/TS falls back to package exports and looks for packages/kitcn/dist/auth/start/server/index.js, which is absent in a fresh checkout unless packages/kitcn has been built first. This breaks scenario:prepare/fixture dev flows in clean environments; add a matching kitcn/auth/start/server mapping in fixture path generation.
Useful? React with 👍 / 👎.
🐛 Fixes local package bug (no tracker issue)
🟢 95-100% confidence
bun test packages/kitcn/src/auth-start/index.test.ts --test-name-pattern 'statically traceable'bun check✅ Outcome
kitcn/auth/startnow statically imports@tanstack/react-start/server.@tanstack/react-startas optional peer + package dev dependency.🏗️ Design
traceDepswould force every Start user to patch around kitcn.kitcn/auth/startis already the framework-specific surface; no API redesign needed.🧪 Verified
bun test packages/kitcn/src/auth-start/index.test.ts --test-name-pattern 'statically traceable'fails before fix.bun test packages/kitcn/src/auth-start/index.test.ts packages/kitcn/src/auth-start/index.retry.test.tsbun --cwd packages/kitcn buildrg -n "@tanstack/react-start/server|import\\(" packages/kitcn/dist/auth/start/index.js packages/kitcn/src/auth-start/index.tsbun lint:fixbun typecheckbun test packages/kitcn/src/package-intent.test.ts --test-name-pattern 'declares intent metadata'GIT_TERMINAL_PROMPT=0 bun check