fix: preserve null Convex query results#264
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 724bdc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fixes ConvexQueryClient dropping valid
nullsubscription results🟢 95-100% confidence
bun check✅ Outcome
nullsubscription results now replace existing React and Solid TanStack Query data.undefinedstill preserves existing hydrated data while the subscription has no server value yet.🏗️ Design
ConvexQueryClient.onUpdateQueryKeyHashin React and Solid.nullfrom cache-stale behavior after the bridge drops it.nullas data; only kitcn's nullish guard diverged.🧪 Verified
bun test packages/kitcn/src/react/client.lifecycle.test.tsbun run test:vitest -- packages/kitcn/src/solid/client.lifecycle.vitest.tsbun lint:fixbun --cwd packages/kitcn buildbun typecheckbun check