Two Test-Cases Added: Test 3 rounds with 8 players#27
Open
bijalthanawala wants to merge 3 commits intoudacity:masterfrom
Open
Two Test-Cases Added: Test 3 rounds with 8 players#27bijalthanawala wants to merge 3 commits intoudacity:masterfrom
bijalthanawala wants to merge 3 commits intoudacity:masterfrom
Conversation
bijalthanawala
changed the title
|
Why hasn't this branch been merged into master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please merge if deemed to be useful (my branch: test_3_rounds_8_players)
Added two extra test-routines in tournament_test.py:
testReportMatches_8players() and testPairings_8players_3rounds()
The purpose of these new routines is to test 8 players and 3 rounds test-cases.
I have left the two original test-routines (testReportMatches() and testPairings())
as it is, for this reason:
(a) The original routines present simpler, smaller test data for students with beginner-level programmer skills to deal with/debug their code against
Glad to answer any questions regarding this merge request or be of help adding any more test-cases or perform any cleanup in the existing tournament_test.py