Drop only dictionaries of type Eq, Ord, Numerical, and ~#1606
Open
yiyunliu wants to merge 1 commit intoucsd-progsys:developfrom
Open
Drop only dictionaries of type Eq, Ord, Numerical, and ~#1606yiyunliu wants to merge 1 commit intoucsd-progsys:developfrom
yiyunliu wants to merge 1 commit intoucsd-progsys:developfrom
Conversation
Collaborator
|
@nikivazou do you know what is the status of this PR? Should it be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once typeclass support is properly implemented, we should no longer drop dictionaries (term level) and class constraints (type level), with the exception of Eq, Ord, Numerical (Num, Integral, etc.).
While tests for class-laws would definitely break, I want use this PR to see if there's anything else that will be broken that I did not expect.