change update_score_and_comments to wrap args#602
Open
breed wants to merge 1 commit intoucfopen:developfrom
Open
change update_score_and_comments to wrap args#602breed wants to merge 1 commit intoucfopen:developfrom
breed wants to merge 1 commit intoucfopen:developfrom
Conversation
when calling update_score_and_comments on a quiz submission, the attempt is already in self and there will be only one item in the update list. this change wraps the passed arguments in a unary quiz_submissions list if quiz_submissions is not one of the parameters to the call. legacy behavior is preserved if quiz_submissions is in the calling parameters.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when calling update_score_and_comments on a quiz submission, the attempt is already in self and there will be only one item in the update list.
Proposed Changes
this change wraps the passed arguments in a unary quiz_submissions list if quiz_submissions is not one of the parameters to the call.
legacy behavior is preserved if quiz_submissions is in the calling parameters.
Fixes #601