feat: use fw charge control from kernel#1775
Conversation
There was a problem hiding this comment.
Pull request overview
This PR appears to switch Framework charge-control support away from the out-of-tree framework-laptop akmod and toward an in-kernel approach by enabling a cros_charge_control module parameter via modprobe configuration.
Changes:
- Add a modprobe.d configuration to set
cros_charge_controlprobe_with_fwk_charge_control=1. - Stop installing the
*framework-laptop*.rpmkmod from the akmods bundle during the base image build.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
system_files/shared/usr/lib/modprobe.d/fw-charge-control.conf |
Adds a module options file to enable Framework charge-control probing via cros_charge_control. |
build_files/base/04-install-kernel-akmods.sh |
Removes installation of the framework-laptop kmod RPM; keeps other optional kmod installs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I think we should probably add this to common, if it's in the mainline Linux kernel then I don't see any reason to not do that |
right, i'll move the kernel stuff to common |
|
My FW laptop is still on the fritz. So if someone could test that this works (it should work fine). I think there was a comment in FW forums, that you cannot use the BIOS setting with together with this as they are "not compatbile". |
1d7de80 to
99a7037
Compare
|
will test this on the weekend on my 2023 one again |
renner0e
left a comment
There was a problem hiding this comment.
yeah this works like I described in: #1151
we could probably put this in bluefin common
get-aurora-dev/common#116
Needs get-aurora-dev/common#116
related #1151