Skip to content

feat: use fw charge control from kernel#1775

Merged
inffy merged 1 commit intoublue-os:mainfrom
inffy:framework-options
Feb 21, 2026
Merged

feat: use fw charge control from kernel#1775
inffy merged 1 commit intoublue-os:mainfrom
inffy:framework-options

Conversation

@inffy
Copy link
Copy Markdown
Member

@inffy inffy commented Feb 17, 2026

Copilot AI review requested due to automatic review settings February 17, 2026 16:06
@inffy inffy changed the title add kernel options feat: add kernel options for framework charge control Feb 17, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR appears to switch Framework charge-control support away from the out-of-tree framework-laptop akmod and toward an in-kernel approach by enabling a cros_charge_control module parameter via modprobe configuration.

Changes:

  • Add a modprobe.d configuration to set cros_charge_control probe_with_fwk_charge_control=1.
  • Stop installing the *framework-laptop*.rpm kmod from the akmods bundle during the base image build.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
system_files/shared/usr/lib/modprobe.d/fw-charge-control.conf Adds a module options file to enable Framework charge-control probing via cros_charge_control.
build_files/base/04-install-kernel-akmods.sh Removes installation of the framework-laptop kmod RPM; keeps other optional kmod installs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@renner0e
Copy link
Copy Markdown
Member

I think we should probably add this to common, if it's in the mainline Linux kernel then I don't see any reason to not do that

@inffy
Copy link
Copy Markdown
Member Author

inffy commented Feb 17, 2026

I think we should probably add this to common, if it's in the mainline Linux kernel then I don't see any reason to not do that

right, i'll move the kernel stuff to common

@inffy inffy changed the title feat: add kernel options for framework charge control feat: use fw charge control from kernel Feb 17, 2026
@inffy inffy marked this pull request as ready for review February 17, 2026 22:38
@inffy inffy enabled auto-merge February 17, 2026 22:38
@inffy
Copy link
Copy Markdown
Member Author

inffy commented Feb 18, 2026

My FW laptop is still on the fritz. So if someone could test that this works (it should work fine).

I think there was a comment in FW forums, that you cannot use the BIOS setting with together with this as they are "not compatbile".

@inffy inffy force-pushed the framework-options branch from 1d7de80 to 99a7037 Compare February 18, 2026 09:23
@renner0e
Copy link
Copy Markdown
Member

will test this on the weekend on my 2023 one again

Copy link
Copy Markdown
Member

@renner0e renner0e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this works like I described in: #1151

we could probably put this in bluefin common
get-aurora-dev/common#116

@inffy inffy added this pull request to the merge queue Feb 21, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 21, 2026
@inffy inffy added this pull request to the merge queue Feb 21, 2026
Merged via the queue into ublue-os:main with commit 8d803b7 Feb 21, 2026
20 checks passed
@inffy inffy deleted the framework-options branch February 21, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants