Skip to content

Jolt: fix Compound shapes not initializing their _shape #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Slin merged 2 commits into from
Apr 13, 2026
Merged

Jolt: fix Compound shapes not initializing their _shape #49

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f09ae4b
Jolt: fix Compound shapes not initializing their _shape
twhlynch Mar 14, 2026
3c06b87
Jolt: remove unimplemented positions and rotations from JoltCompoundS…
twhlynch Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Modules/Jolt/RNJoltShape.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ namespace RN

JoltCompoundShape::JoltCompoundShape()
{
_shape = new JPH::MutableCompoundShape();
_shape->AddRef();
}

JoltCompoundShape::JoltCompoundShape(Model *model, JoltMaterial *material, Vector3 scale, bool useTriangleMesh, bool wantsDoubleSided)
Expand All @@ -229,6 +231,9 @@ namespace RN

JoltCompoundShape::JoltCompoundShape(const Array *meshes, JoltMaterial *material, Vector3 scale, bool useTriangleMesh, bool wantsDoubleSided)
{
_shape = new JPH::MutableCompoundShape();
_shape->AddRef();

meshes->Enumerate<Mesh>([&](Mesh *mesh, size_t index, bool &stop) {
AddChild(mesh, material, Vector3(), Quaternion(), scale, useTriangleMesh, wantsDoubleSided);
});
Comment thread
twhlynch marked this conversation as resolved.
Expand Down
Loading