[PENDING] refactor(graphrunner): route metrics through observability/metrics#197
Merged
Conversation
xytan0056
force-pushed
the
pr6-orchestrator
branch
from
July 14, 2026 02:18
e6a6778 to
810d33d
Compare
xytan0056
force-pushed
the
pr7-graphrunner
branch
2 times, most recently
from
July 14, 2026 02:26
cb838a0 to
d12204f
Compare
xytan0056
force-pushed
the
pr6-orchestrator
branch
from
July 14, 2026 02:26
810d33d to
b8d9aae
Compare
xytan0056
force-pushed
the
pr6-orchestrator
branch
from
July 14, 2026 02:37
b8d9aae to
54b29c4
Compare
xytan0056
force-pushed
the
pr7-graphrunner
branch
from
July 14, 2026 02:37
d12204f to
489af72
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[PENDING] — do not merge until pr6-orchestrator lands
Routes the native graphrunner's metrics through
observability/metrics.ctxviametrics.FromContext(the orchestrator forwards the same ctx the controller seeded), so it no longer takes atally.Scopeat construction.bazel_query_duration,git_file_hashes_duration,target_hash_duration) and the target-count gauge move to shared metric-name constants under thegraph_runnerop sub-scope.target_count→targets_count, still a gauge to preserve the time-series shape.Scopeplumbing (Params.Scope+ the threaded field) is now dead and removed.Stacking / dependency
Based on pr6-orchestrator. Independent of #174. Same as pr6: the emitter is seeded by the controller PR (pr5); until then
FromContextreturns the noop emitter (safe).