Skip to content

[PENDING] refactor(graphrunner): route metrics through observability/metrics#197

Merged
xytan0056 merged 0 commit into
pr6-orchestratorfrom
pr7-graphrunner
Jul 14, 2026
Merged

[PENDING] refactor(graphrunner): route metrics through observability/metrics#197
xytan0056 merged 0 commit into
pr6-orchestratorfrom
pr7-graphrunner

Conversation

@xytan0056

@xytan0056 xytan0056 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

[PENDING] — do not merge until pr6-orchestrator lands

Routes the native graphrunner's metrics through observability/metrics.

  • The graphrunner reads the request emitter from ctx via metrics.FromContext (the orchestrator forwards the same ctx the controller seeded), so it no longer takes a tally.Scope at construction.
  • Substep timers (bazel_query_duration, git_file_hashes_duration, target_hash_duration) and the target-count gauge move to shared metric-name constants under the graph_runner op sub-scope. target_counttargets_count, still a gauge to preserve the time-series shape.
  • With the runner taking its emitter from ctx, the orchestrator's Scope plumbing (Params.Scope + the threaded field) is now dead and removed.

Stacking / dependency

Based on pr6-orchestrator. Independent of #174. Same as pr6: the emitter is seeded by the controller PR (pr5); until then FromContext returns the noop emitter (safe).

@xytan0056
xytan0056 requested review from a team as code owners July 14, 2026 01:52
@xytan0056
xytan0056 force-pushed the pr7-graphrunner branch 2 times, most recently from cb838a0 to d12204f Compare July 14, 2026 02:26
@xytan0056
xytan0056 merged commit 489af72 into pr6-orchestrator Jul 14, 2026
@xytan0056

Copy link
Copy Markdown
Contributor Author

Superseded by #198. GitHub auto-marked this PR as "merged" when the stack order was flipped so the graphrunner change lands before the orchestrator change (it couldn't be reopened). The graphrunner work now lives in #198 (based on pr4-context).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant