[PENDING] refactor(orchestrator): route metrics through observability/metrics#196
Closed
xytan0056 wants to merge 1 commit into
Closed
[PENDING] refactor(orchestrator): route metrics through observability/metrics#196xytan0056 wants to merge 1 commit into
xytan0056 wants to merge 1 commit into
Conversation
xytan0056
force-pushed
the
pr6-orchestrator
branch
3 times, most recently
from
July 14, 2026 02:37
b8d9aae to
54b29c4
Compare
The orchestrator reads the request emitter from ctx via metrics.FromContext instead of building its own from an injected tally.Scope. The controller seeds the emitter (emitter=service + repo tags) at the request boundary, so every layer below shares one series without re-deriving tags. FromContext is noop-safe, so the orchestrator still works when driven standalone. The open-coded calls/success/failure + failure_type classification block collapses into TrackInFlight + metrics.RecordRequest under the native_orchestrator op sub-scope. With the graphrunner already reading its emitter from ctx, the orchestrator's tally.Scope plumbing (Params.Scope + the threaded field) is now dead and removed.
xytan0056
force-pushed
the
pr7-graphrunner
branch
from
July 14, 2026 05:53
489af72 to
a48bdee
Compare
xytan0056
force-pushed
the
pr6-orchestrator
branch
from
July 14, 2026 05:53
54b29c4 to
2c77bbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routes the native orchestrator's metrics through
observability/metricsinstead of open-coding tally.the orchestrator reads the request emitter from
ctxviametrics.FromContextcalls/success/failure+failure_typeclassification block collapses intoTrackInFlight+metrics.RecordRequestunder thenative_orchestratorop sub-scope.FromContextis noop-safe (never nil), so the orchestrator still works when driven standalone.tally.Scopehere; it migrates toFromContextin the stacked graphrunner PR.Stacking