[config] Tango configuration documentation by yushan8 · Pull Request #180 · uber/tango

yushan8 · 2026-07-10T22:31:03Z

Summary

Documents all user-facing configuration fields across service, repository, and storage sections.

Test plan

make build
make test

Stack

Summary: Intent: - This branch builds on #180 (docs: add config/README.md), which documented the intended shape of the YAML config surface. Several documented field names, defaults, and required-ness didn't match the actual Go structs and Parse() behavior; this aligns the code with the docs. Changes: - Renamed config fields to match config/README.md: worker_pool_size -> max_worker_pool_size, repo_manager_clone_path -> workspaces_root, chunking -> streaming (and its target_chunk_size/changed_target_chunk_size/ metadata_map_chunk_size -> max_num_targets/max_num_changed_targets/ max_num_metadata_entries), query_timeout -> query_timeout_seconds. - config.Parse now enforces service.workspaces_root as required (previously silently defaulted to a temp dir) and applies the documented defaults: bzlmod_enabled defaults to true, query_timeout_seconds defaults to 600, and the streaming.max_num_* fields default to 250/125/50000. - Added Go doc comments for the config fields documented in the README. - Updated all call sites (controller, example/main.go, orchestrator/native_orchestrator.go) and YAML fixtures for the renames. - Added config/config_test.go covering the new validation and defaults. --- Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace

sywhang · 2026-07-14T16:47:42Z

+repository:
+  - remote: "https://github.com/uber/tango.git"
+    bzlmod_enabled: true
+    # query_timeout_seconds: 600


is this meant to be commented out? It is documented in the table below

Commented out means that it's optional, but I can uncomment it if it's not clear.

sywhang · 2026-07-14T17:26:48Z

+| Field | Required | Type | Default | Description |
+|---|---|---|---|---|
+| `remote` | **Yes** | `string` | | The URL used to `git clone` the repository. Tango clones from this URL and uses it as the lookup key for per-repo settings. Must be unique across all entries and match exactly what clients send in `BuildDescription.remote`. |
+| `bzlmod_enabled` | No | `bool` | `true` | Whether this repository uses Bzlmod for external dependency management. Bzlmod is enforced in Bazel 9+. Set to false only for repositories still using WORKSPACE — when disabled, `//external:all-targets` is added to Bazel queries. Setting this incorrectly causes query failures — it must match the repository's actual dependency management setup. |


Is this right? i don't see default true being set anywhere in the codebase. Where is that set?

This will be updated in subsequent PRs. This README.md has changes so we can finalize how the config will look. Will update now that the config fields is finalized.

sywhang · 2026-07-14T17:27:27Z

+|---|---|---|---|---|
+| `remote` | **Yes** | `string` | | The URL used to `git clone` the repository. Tango clones from this URL and uses it as the lookup key for per-repo settings. Must be unique across all entries and match exactly what clients send in `BuildDescription.remote`. |
+| `bzlmod_enabled` | No | `bool` | `true` | Whether this repository uses Bzlmod for external dependency management. Bzlmod is enforced in Bazel 9+. Set to false only for repositories still using WORKSPACE — when disabled, `//external:all-targets` is added to Bazel queries. Setting this incorrectly causes query failures — it must match the repository's actual dependency management setup. |
+| `bazel_command` | No | `string` | `""` | Override the Bazel binary path. When empty, Tango automatically downloads and caches [Bazelisk](https://github.com/bazelbuild/bazelisk) from GitHub. This lets Tango run without Bazel pre-installed and allows each repository to control its own Bazel version via `.bazelversion`. Set this when the repository requires a custom Bazel wrapper script. |


usually configs like these have path suffix.

gotcha 👍

Summary: Intent: - This branch builds on #180 (docs: add config/README.md), which documented the intended shape of the YAML config surface. Several documented field names, defaults, and required-ness didn't match the actual Go structs and Parse() behavior; this aligns the code with the docs. Changes: - Renamed config fields to match config/README.md: worker_pool_size -> max_worker_pool_size, repo_manager_clone_path -> workspaces_root, chunking -> streaming (and its target_chunk_size/changed_target_chunk_size/ metadata_map_chunk_size -> max_num_targets/max_num_changed_targets/ max_num_metadata_entries), query_timeout -> query_timeout_seconds. - config.Parse now enforces service.workspaces_root as required (previously silently defaulted to a temp dir) and applies the documented defaults: bzlmod_enabled defaults to true, query_timeout_seconds defaults to 600, and the streaming.max_num_* fields default to 250/125/50000. - Added Go doc comments for the config fields documented in the README. - Updated all call sites (controller, example/main.go, orchestrator/native_orchestrator.go) and YAML fixtures for the renames. - Added config/config_test.go covering the new validation and defaults. --- Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace

Documents the service, repository, and storage config sections with field-level tables (required/type/default/description) and example YAML snippets.

Summary: Intent: - This branch builds on #180 (docs: add config/README.md), which documented the intended shape of the YAML config surface. Several documented field names, defaults, and required-ness didn't match the actual Go structs and Parse() behavior; this aligns the code with the docs. Changes: - Renamed config fields to match config/README.md: worker_pool_size -> max_worker_pool_size, repo_manager_clone_path -> workspaces_root, chunking -> streaming (and its target_chunk_size/changed_target_chunk_size/ metadata_map_chunk_size -> max_num_targets/max_num_changed_targets/ max_num_metadata_entries), query_timeout -> query_timeout_seconds. - config.Parse now enforces service.workspaces_root as required (previously silently defaulted to a temp dir) and applies the documented defaults: bzlmod_enabled defaults to true, query_timeout_seconds defaults to 600, and the streaming.max_num_* fields default to 250/125/50000. - Added Go doc comments for the config fields documented in the README. - Updated all call sites (controller, example/main.go, orchestrator/native_orchestrator.go) and YAML fixtures for the renames. - Added config/config_test.go covering the new validation and defaults. --- Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace

yushan8 changed the title ~~docs(config): add configuration reference~~ docs(config): RFC add configuration reference Jul 10, 2026

yushan8 changed the title ~~docs(config): RFC add configuration reference~~ docs(config): Tango configuration RFC Jul 10, 2026

yushan8 marked this pull request as ready for review July 10, 2026 22:33

yushan8 requested review from a team as code owners July 10, 2026 22:33

yushan8 marked this pull request as draft July 10, 2026 22:33

yushan8 marked this pull request as ready for review July 10, 2026 22:54