[draft/wip] test(stovepipe): cover process pipeline integration#395
Draft
mnoah1 wants to merge 1 commit into
Draft
[draft/wip] test(stovepipe): cover process pipeline integration#395mnoah1 wants to merge 1 commit into
mnoah1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ingest -> process -> buildoutcome, not only a process-consumer acknowledgmentBehaviors covered
Cold-start admission and build handoff
A request ingested through the public gRPC API must reach
processing, use the full-build strategy with no baseline, claim exactly one in-flight slot, retain the queue's latest-head pointer, and publish a decodableBuildRequestfor the same request ID. This proves the process stage performed its business transition and downstream handoff; an ack by itself could also represent a deliberate no-op.Stale-head coalescing
When an older accepted request is delivered after
latest_request_idpoints to a newer request, the older request must becomesuperseded, the newer request must remain accepted, and no build slot may be consumed. This protects queue capacity and prevents obsolete work from reaching build.Idempotent redelivery
Delivering a distinct queue message that references an already-processing request must leave the request processing, keep
in_flight_countat one, and retain exactly one build message. This verifies at-least-once delivery cannot double-claim capacity or duplicate downstream work.Non-retryable failure and DLQ reconciliation
A valid process payload that fails request-ID comparison non-retryably must route through
process_dlq; the DLQ consumer must reconcile the request torecorded_not_green, leave no slot claimed, and publish no build work. This verifies the real classifier, MySQL queue DLQ routing, and reconciliation consumer fail closed together.Test plan
./tool/bazel test //test/integration/stovepipe:go_default_test //test/e2e/stovepipe:go_default_test --test_output=errors