[7/N] feat(gateway): add request history lookups#346
Merged
Conversation
This was referenced Jul 13, 2026
albertywu
marked this pull request as ready for review
July 13, 2026 23:23
albertywu
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
July 13, 2026 23:23
albertywu
force-pushed
the
wua/request-list-api
branch
from
July 15, 2026 02:51
8ec34b2 to
58b2eca
Compare
albertywu
force-pushed
the
wua/request-history-api
branch
from
July 15, 2026 02:51
245a0cb to
25e5a88
Compare
albertywu
marked this pull request as draft
July 15, 2026 02:52
albertywu
force-pushed
the
wua/request-list-api
branch
from
July 15, 2026 04:06
58b2eca to
df83074
Compare
albertywu
force-pushed
the
wua/request-history-api
branch
from
July 15, 2026 04:06
25e5a88 to
19e6f6e
Compare
albertywu
marked this pull request as ready for review
July 15, 2026 04:14
albertywu
force-pushed
the
wua/request-history-api
branch
from
July 15, 2026 04:31
19e6f6e to
d60e77a
Compare
albertywu
force-pushed
the
wua/request-list-api
branch
from
July 15, 2026 04:31
df83074 to
7cee179
Compare
behinddwalls
approved these changes
Jul 15, 2026
albertywu
force-pushed
the
wua/request-history-api
branch
from
July 15, 2026 17:19
d60e77a to
d814bd6
Compare
albertywu
force-pushed
the
wua/request-list-api
branch
2 times, most recently
from
July 15, 2026 18:40
c5bc7ac to
aa17591
Compare
albertywu
force-pushed
the
wua/request-history-api
branch
from
July 15, 2026 18:40
d814bd6 to
26eb41e
Compare
roychying
pushed a commit
to roychying/submitqueue
that referenced
this pull request
Jul 15, 2026
## Summary Add storage contracts, MySQL implementations, generated mocks, and integration coverage for request summaries, queue projections, and change URI mappings. ## Test Plan ✅ `make fmt && make build && make test && make e2e-test` ## Issues ## Stack 1. @ uber#340 1. uber#341 1. uber#342 1. uber#343 1. uber#344 1. uber#345 1. uber#346
albertywu
force-pushed
the
wua/request-history-api
branch
from
July 15, 2026 21:33
26eb41e to
5efc23f
Compare
albertywu
force-pushed
the
wua/request-list-api
branch
from
July 15, 2026 21:33
aa17591 to
d9792df
Compare
behinddwalls
force-pushed
the
wua/request-list-api
branch
from
July 15, 2026 21:43
d9792df to
0ff103e
Compare
behinddwalls
force-pushed
the
wua/request-history-api
branch
from
July 15, 2026 21:43
5efc23f to
964ceb4
Compare
behinddwalls
force-pushed
the
wua/request-list-api
branch
from
July 15, 2026 21:50
0ff103e to
cce7830
Compare
behinddwalls
force-pushed
the
wua/request-history-api
branch
from
July 15, 2026 21:50
964ceb4 to
68039d7
Compare
behinddwalls
force-pushed
the
wua/request-history-api
branch
from
July 15, 2026 21:55
68039d7 to
95b14c4
Compare
albertywu
enabled auto-merge
July 15, 2026 21:55
behinddwalls
pushed a commit
to roychying/submitqueue
that referenced
this pull request
Jul 16, 2026
behinddwalls
pushed a commit
to roychying/submitqueue
that referenced
this pull request
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat(gateway): add request history lookups
Test Plan
✅
make fmt && make build && make test && make e2e-testLocal full-stack gRPC verification
2026-07-15d814bd69c547418294ba684d49900264189a48femake local-submitqueue-start.grpcurlusingapi/submitqueue/gateway/proto/gateway.proto.erroras a duplicate of the in-flight request.GetRequestSummaryByIDlastError.GetRequestSummaryByChangeURIListpageSize: 1.GetRequestHistoryByIDlandedanderror.GetRequestHistoryByChangeURIlastError.Exact gRPC requests and stdout
Setup: Land request 1RPC:
uber.submitqueue.gateway.SubmitQueueGateway/LandRequest:
{"queue":"e2e-test-queue","change":{"uris":["github://uber/grpc-verification/pull/790/d814bd69c547418294ba684d49900264189a48fe"]},"strategy":"REBASE"}STDOUT:
{ "sqid": "e2e-test-queue/1" }Setup: Land request 2 with the same pinned changeRPC:
uber.submitqueue.gateway.SubmitQueueGateway/LandRequest:
{"queue":"e2e-test-queue","change":{"uris":["github://uber/grpc-verification/pull/790/d814bd69c547418294ba684d49900264189a48fe"]},"strategy":"REBASE"}STDOUT:
{ "sqid": "e2e-test-queue/2" }GetRequestSummaryByID: successful requestRPC:
uber.submitqueue.gateway.SubmitQueueGateway/GetRequestSummaryByIDRequest:
{"sqid":"e2e-test-queue/1"}STDOUT:
{ "request": { "sqid": "e2e-test-queue/1", "queue": "e2e-test-queue", "changeUris": [ "github://uber/grpc-verification/pull/790/d814bd69c547418294ba684d49900264189a48fe" ], "receivedAtMs": "1784136105896", "status": "landed", "metadata": { "batch_id": "e2e-test-queue/batch/1" } } }GetRequestSummaryByID: duplicate requestRPC:
uber.submitqueue.gateway.SubmitQueueGateway/GetRequestSummaryByIDRequest:
{"sqid":"e2e-test-queue/2"}STDOUT:
{ "request": { "sqid": "e2e-test-queue/2", "queue": "e2e-test-queue", "changeUris": [ "github://uber/grpc-verification/pull/790/d814bd69c547418294ba684d49900264189a48fe" ], "receivedAtMs": "1784136105938", "status": "error", "lastError": "request e2e-test-queue/2 is a duplicate of in-flight request e2e-test-queue/1" } }GetRequestSummaryByChangeURIRPC:
uber.submitqueue.gateway.SubmitQueueGateway/GetRequestSummaryByChangeURIRequest:
{"changeUri":"github://uber/grpc-verification/pull/790/d814bd69c547418294ba684d49900264189a48fe"}STDOUT:
{ "requests": [ { "sqid": "e2e-test-queue/2", "queue": "e2e-test-queue", "changeUris": [ "github://uber/grpc-verification/pull/790/d814bd69c547418294ba684d49900264189a48fe" ], "receivedAtMs": "1784136105938", "status": "error", "lastError": "request e2e-test-queue/2 is a duplicate of in-flight request e2e-test-queue/1" }, { "sqid": "e2e-test-queue/1", "queue": "e2e-test-queue", "changeUris": [ "github://uber/grpc-verification/pull/790/d814bd69c547418294ba684d49900264189a48fe" ], "receivedAtMs": "1784136105896", "status": "landed", "metadata": { "batch_id": "e2e-test-queue/batch/1" } } ] }List: first pageRPC:
uber.submitqueue.gateway.SubmitQueueGateway/ListRequest:
{"queue":"e2e-test-queue","receivedAtOrAfterMs":1784136105896,"receivedBeforeMs":1784136105939,"pageSize":1}STDOUT:
{ "requests": [ { "sqid": "e2e-test-queue/2", "queue": "e2e-test-queue", "changeUris": [ "github://uber/grpc-verification/pull/790/d814bd69c547418294ba684d49900264189a48fe" ], "receivedAtMs": "1784136105938", "status": "error", "lastError": "request e2e-test-queue/2 is a duplicate of in-flight request e2e-test-queue/1" } ], "nextPageToken": "bGFzdF9yZWNlaXZlZF9hdF9tcz0xNzg0MTM2MTA1OTM4Jmxhc3RfcmVxdWVzdF9pZD1lMmUtdGVzdC1xdWV1ZSUyRjImcXVldWU9ZTJlLXRlc3QtcXVldWUmcmVjZWl2ZWRfYXRfb3JfYWZ0ZXJfbXM9MTc4NDEzNjEwNTg5NiZyZWNlaXZlZF9iZWZvcmVfbXM9MTc4NDEzNjEwNTkzOQ" }List: second pageRPC:
uber.submitqueue.gateway.SubmitQueueGateway/ListRequest:
{"queue":"e2e-test-queue","receivedAtOrAfterMs":1784136105896,"receivedBeforeMs":1784136105939,"pageSize":1,"pageToken":"bGFzdF9yZWNlaXZlZF9hdF9tcz0xNzg0MTM2MTA1OTM4Jmxhc3RfcmVxdWVzdF9pZD1lMmUtdGVzdC1xdWV1ZSUyRjImcXVldWU9ZTJlLXRlc3QtcXVldWUmcmVjZWl2ZWRfYXRfb3JfYWZ0ZXJfbXM9MTc4NDEzNjEwNTg5NiZyZWNlaXZlZF9iZWZvcmVfbXM9MTc4NDEzNjEwNTkzOQ"}STDOUT:
{ "requests": [ { "sqid": "e2e-test-queue/1", "queue": "e2e-test-queue", "changeUris": [ "github://uber/grpc-verification/pull/790/d814bd69c547418294ba684d49900264189a48fe" ], "receivedAtMs": "1784136105896", "status": "landed", "metadata": { "batch_id": "e2e-test-queue/batch/1" } } ] }GetRequestHistoryByID: successful requestRPC:
uber.submitqueue.gateway.SubmitQueueGateway/GetRequestHistoryByIDRequest:
{"sqid":"e2e-test-queue/1"}STDOUT:
{ "events": [ { "timestampMs": "1784136105896", "status": "accepted" }, { "timestampMs": "1784136106080", "status": "started" }, { "timestampMs": "1784136106791", "status": "batched", "metadata": { "batch_id": "e2e-test-queue/batch/1" } }, { "timestampMs": "1784136106965", "status": "scored", "metadata": { "batch_id": "e2e-test-queue/batch/1", "score": "0.7000" } }, { "timestampMs": "1784136108484", "status": "landed", "metadata": { "batch_id": "e2e-test-queue/batch/1" } } ] }GetRequestHistoryByID: duplicate requestRPC:
uber.submitqueue.gateway.SubmitQueueGateway/GetRequestHistoryByIDRequest:
{"sqid":"e2e-test-queue/2"}STDOUT:
{ "events": [ { "timestampMs": "1784136105938", "status": "accepted" }, { "timestampMs": "1784136106086", "status": "started" }, { "timestampMs": "1784136106461", "status": "error", "lastError": "request e2e-test-queue/2 is a duplicate of in-flight request e2e-test-queue/1" } ] }GetRequestHistoryByChangeURIRPC:
uber.submitqueue.gateway.SubmitQueueGateway/GetRequestHistoryByChangeURIRequest:
{"changeUri":"github://uber/grpc-verification/pull/790/d814bd69c547418294ba684d49900264189a48fe"}STDOUT:
{ "histories": [ { "sqid": "e2e-test-queue/1", "events": [ { "timestampMs": "1784136105896", "status": "accepted" }, { "timestampMs": "1784136106080", "status": "started" }, { "timestampMs": "1784136106791", "status": "batched", "metadata": { "batch_id": "e2e-test-queue/batch/1" } }, { "timestampMs": "1784136106965", "status": "scored", "metadata": { "batch_id": "e2e-test-queue/batch/1", "score": "0.7000" } }, { "timestampMs": "1784136108484", "status": "landed", "metadata": { "batch_id": "e2e-test-queue/batch/1" } } ] }, { "sqid": "e2e-test-queue/2", "events": [ { "timestampMs": "1784136105938", "status": "accepted" }, { "timestampMs": "1784136106086", "status": "started" }, { "timestampMs": "1784136106461", "status": "error", "lastError": "request e2e-test-queue/2 is a duplicate of in-flight request e2e-test-queue/1" } ] } ] }Issues
Stack