Skip to content

Downgrade PortUnreachableException in UDP flush from an exception to a warn log. #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamjeanlaurent merged 6 commits into from
Dec 12, 2025
Merged

Downgrade PortUnreachableException in UDP flush from an exception to a warn log. #132

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f6c8bb5
log portunreachable exception
adamjeanlaurent Dec 11, 2025
943d5b6
import portunreachable exception
adamjeanlaurent Dec 11, 2025
6dad5d2
change log message
adamjeanlaurent Dec 11, 2025
280fd9e
fix unused impoty
adamjeanlaurent Dec 11, 2025
d63c56c
warn level
adamjeanlaurent Dec 11, 2025
bf5ecb2
release version 0.14.3
adamjeanlaurent Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion core/src/main/java/com/uber/m3/tally/ScopeImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import javax.annotation.Nullable;
import java.util.Collection;
import java.util.Map;
import java.util.Optional;
Comment thread
adamjeanlaurent marked this conversation as resolved.
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.CopyOnWriteArrayList;
import java.util.concurrent.ScheduledExecutorService;
Expand Down
3 changes: 3 additions & 0 deletions m3/src/main/java/com/uber/m3/tally/m3/thrift/TUdpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import java.io.IOException;
import java.net.DatagramPacket;
import java.net.DatagramSocket;
import java.net.PortUnreachableException;
import java.net.SocketAddress;
import java.net.SocketException;

Expand Down Expand Up @@ -68,6 +69,8 @@ public void flush() throws TTransportException {
// directly
new DatagramPacket(writeBuffer.array(), writeBuffer.position())
);
} catch (PortUnreachableException e) {
logger.warn("UDP port unreachable during flush");
} catch (IOException e) {
throw new TTransportException(e);
} finally {
Expand Down
Loading