Skip to content

FIX replace nose with pytest for Python 3.10 compatibility#1068

Merged
catinhere merged 1 commit intomasterfrom
nose-removal
Apr 2, 2026
Merged

FIX replace nose with pytest for Python 3.10 compatibility#1068
catinhere merged 1 commit intomasterfrom
nose-removal

Conversation

@xcompass
Copy link
Copy Markdown
Member

nose 1.3.7 is abandoned and incompatible with Python 3.10 (removed collections.Callable). Replace nosetests with pytest in Makefile targets (testb, testb-coverage, testb-profile, testci) and swap nose==1.3.7 for pytest + pytest-cov in requirements.txt.

nose 1.3.7 is abandoned and incompatible with Python 3.10 (removed
collections.Callable). Replace nosetests with pytest in Makefile targets
(testb, testb-coverage, testb-profile, testci) and swap nose==1.3.7 for
pytest + pytest-cov in requirements.txt.
@xcompass xcompass requested a review from ionparticle March 13, 2026 07:52
@xcompass
Copy link
Copy Markdown
Member Author

won't have time to test it before I'm off. Please test it before merge.

@catinhere catinhere merged commit 932eb0e into master Apr 2, 2026
8 checks passed
@catinhere
Copy link
Copy Markdown
Contributor

Tested locally and inside container. BE tests are running fine with pytest.

There are currently two test failures:

  • test_create_attachment in test_file.py: due to change in 0734c58. uuid and filename are not the same anymore
  • test_saml_metadata in test_file.py: only fails running inside container because SAML_METADATA_URL="https://samltest.id/saml/idp", which no longer exists. Perhaps we should mock the response returned from OneLogin_Saml2_IdPMetadataParser.parse_remote

Above tests will be updated in another PR

@catinhere catinhere deleted the nose-removal branch April 2, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants