Resolved mismatch stubbings in HttpContentServiceImplTest.java#245
Open
ARMS2025 wants to merge 1 commit intouPortal-Project:masterfrom
Open
Resolved mismatch stubbings in HttpContentServiceImplTest.java#245ARMS2025 wants to merge 1 commit intouPortal-Project:masterfrom
ARMS2025 wants to merge 1 commit intouPortal-Project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I analyzed the test doubles (mocks) in the test code of the project. In my analysis of the project, I observed that
In tests
testPostFormNoParams,testGetForm, andtestGetFormNoParams:getParametermethod for therequestobject:i) during test execution the method is actually called with argument
"proxy.url", but is not stubbed, resulting in mismatch stubbings.In the test
testNonForm:getParametermethod for therequestobject:i) during test execution the method is actually called with argument
"proxy.url", but is not stubbed, resulting in a mismatch stubbing.ii) during test execution the method is actually called with argument
"proxy.formMethod", but is not stubbed, resulting in another mismatch stubbing.In general, a mismatched stubbing occurs when a method is stubbed with specific arguments in a test but later invoked with different arguments in the code. Mockito recommends addressing this type of issue (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org.mockito/org/mockito/exceptions/misusing/PotentialStubbingProblem.html).
I propose a solution below to resolve the mismatch stubbing. Happy to modify the pull request based on your feedback.