Update HttpResponse with beginWrite#1897
Open
notaphplover wants to merge 1 commit intouNetworking:masterfrom
Open
Update HttpResponse with beginWrite#1897notaphplover wants to merge 1 commit intouNetworking:masterfrom
notaphplover wants to merge 1 commit intouNetworking:masterfrom
Conversation
notaphplover
commented
Nov 20, 2025
| @@ -0,0 +1,184 @@ | |||
| #include <iostream> | |||
Author
There was a problem hiding this comment.
I took the liberty of adding some tests, let me know if you prefer to remove them
Contributor
|
This is a good idea, I have missed it. I will probably add this without the tests (the tests are platform dependent and not really deterministic). |
Author
|
Sure, I'll remove them in a commit. If you decide to go with a separate pr instead of this one, could I ask you to co author me in the commit message? This is probably an act of vanity but figuring as a contributor to your repo would be almost a dream come true. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
HttpResponsewithbeginWrite.Context
See #1895