Feat/improve dtc handling

app/src/androidTest/java/org/obd/graphs/DataLoggerWifiTest.kt

@@ -65,9 +65,9 @@ class DataLoggerWifiTest {
 
         tcpTestRunner(
             assert = {
-                assertTrue(vehicleCapabilitiesManager.getDTC().contains("26E400"))
-                assertTrue(vehicleCapabilitiesManager.getDTC().contains("D00800"))
-                assertTrue(vehicleCapabilitiesManager.getDTC().contains("2BC100"))
+                assertTrue(vehicleCapabilitiesManager.getDiagnosticTroubleCodes().contains("26E400"))
+                assertTrue(vehicleCapabilitiesManager.getDiagnosticTroubleCodes().contains("D00800"))
+                assertTrue(vehicleCapabilitiesManager.getDiagnosticTroubleCodes().contains("2BC100"))
             },
             arrange = {
                 // arrange

app/src/main/java/org/obd/graphs/activity/Receivers.kt

@@ -177,8 +177,8 @@ internal fun MainActivity.receive(intent: Intent?) {
             }
 
         REQUEST_PERMISSIONS_BT -> Permissions.requestBluetoothPermissions(this)
-        TOOLBAR_HIDE -> Toolbar.hide(this,true)
-        TOOLBAR_SHOW -> Toolbar.hide(this,false)
+        TOOLBAR_HIDE -> Toolbar.hide(this, true)
+        TOOLBAR_SHOW -> Toolbar.hide(this, false)
         TOOLBAR_TOGGLE_ACTION -> Toolbar.toggle(this)
 
         PROFILE_NAME_CHANGED_EVENT -> updateVehicleProfile()
@@ -220,9 +220,12 @@ internal fun MainActivity.receive(intent: Intent?) {
                     )
             }
 
-            FabButtons.view(this).connectFab.let{
+            FabButtons.view(this).connectFab.let {
                 it.backgroundTintList =
-                    ContextCompat.getColorStateList(applicationContext, org.obd.graphs.commons.R.color.cardinal)
+                    ContextCompat.getColorStateList(
+                        applicationContext,
+                        org.obd.graphs.commons.R.color.cardinal,
+                    )
                 it.setOnClickListener {
                     Log.i(LOG_TAG, "Stop data logging ")
                     withDataLogger {
@@ -257,7 +260,7 @@ internal fun MainActivity.receive(intent: Intent?) {
                 it.start()
             }
 
-            Toolbar.hide(this,true)
+            Toolbar.hide(this, true)
             updateAdapterConnectionType()
         }
 
@@ -293,12 +296,15 @@ private fun MainActivity.handleStop() {
         it.visibility = View.GONE
     }
 
-    FabButtons.view(this).connectFab.let{
+    FabButtons.view(this).connectFab.let {
         it.backgroundTintList =
-            ContextCompat.getColorStateList(applicationContext, org.obd.graphs.commons.R.color.philippine_green)
+            ContextCompat.getColorStateList(
+                applicationContext,
+                org.obd.graphs.commons.R.color.philippine_green,
+            )
     }
 
-    Toolbar.hide(this,false)
+    Toolbar.hide(this, false)
 
     timer {
         it.stop()
@@ -380,12 +386,11 @@ internal fun MainActivity.registerReceiver() {
         it.addAction(PROFILE_NAME_CHANGED_EVENT)
     }
 
-   registerReceiver(this, DataLoggerRepository.broadcastReceivers()) {
+    registerReceiver(this, DataLoggerRepository.broadcastReceivers()) {
         it.addAction(MODULES_LIST_CHANGED_EVENT)
         it.addAction(PROFILE_CHANGED_EVENT)
     }
 
-
     registerReceiver(this, powerReceiver) {
         it.addAction("android.intent.action.ACTION_POWER_CONNECTED")
         it.addAction("android.intent.action.ACTION_POWER_DISCONNECTED")

app/src/main/java/org/obd/graphs/preferences/CoreDialogFragment.kt

@@ -36,7 +36,7 @@ abstract class CoreDialogFragment : DialogFragment() {
         root: View,
         func: () -> Unit = {},
     ) {
-        root.findViewById<Button>(R.id.trip_action_close_window).apply {
+        root.findViewById<Button>(R.id.action_close_window).apply {
             setOnClickListener {
                 func()
                 dialog?.dismiss()

app/src/main/java/org/obd/graphs/preferences/dtc/DiagnosticTroubleCodeListPreferences.kt

@@ -20,7 +20,7 @@ import android.content.Context
 import android.util.AttributeSet
 import androidx.preference.DialogPreference
 
-class DiagnosticTroubleCodeListPreferences(
+ internal class DiagnosticTroubleCodeListPreferences(
     context: Context,
     attrs: AttributeSet?,
 ) : DialogPreference(context, attrs)

app/src/main/java/org/obd/graphs/preferences/dtc/DiagnosticTroubleCodePreferenceDialogFragment.kt

@@ -16,17 +16,42 @@
  */
 package org.obd.graphs.preferences.dtc
 
+import android.content.Intent
 import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
+import android.widget.Button
 import androidx.recyclerview.widget.GridLayoutManager
 import androidx.recyclerview.widget.RecyclerView
 import org.obd.graphs.R
-import org.obd.graphs.bl.datalogger.vehicleCapabilitiesManager
+import org.obd.graphs.bl.datalogger.DATA_LOGGER_DTC_ACTION_COMPLETED
+import org.obd.graphs.bl.datalogger.DataLoggerRepository
+import org.obd.graphs.bl.datalogger.VehicleCapabilitiesManager
 import org.obd.graphs.preferences.CoreDialogFragment
+import org.obd.graphs.registerReceiver
+import org.obd.graphs.ui.common.toast
+import org.obd.graphs.ui.withDataLogger
+import org.obd.metrics.api.model.DiagnosticTroubleCode
+import org.obd.metrics.command.dtc.DtcComponent
+
+internal class DiagnosticTroubleCodePreferenceDialogFragment : CoreDialogFragment() {
+    private lateinit var adapter: DiagnosticTroubleCodeViewAdapter
+    private lateinit var clearButton: Button
+    private lateinit var shareButton: Button
+
+    private val dtcNotificationsReceiver =
+        object : android.content.BroadcastReceiver() {
+            override fun onReceive(
+                context: android.content.Context?,
+                intent: Intent?,
+            ) {
+                if (intent?.action == DATA_LOGGER_DTC_ACTION_COMPLETED) {
+                    handleDTCChangedNotification()
+                }
+            }
+        }
 
-class DiagnosticTroubleCodePreferenceDialogFragment : CoreDialogFragment() {
     override fun onCreateView(
         inflater: LayoutInflater,
         container: ViewGroup?,
@@ -35,18 +60,177 @@ class DiagnosticTroubleCodePreferenceDialogFragment : CoreDialogFragment() {
         requestWindowFeatures()
 
         val root = inflater.inflate(R.layout.dialog_dtc, container, false)
-        val dtc = vehicleCapabilitiesManager.getDTC()
-
-        if (dtc.isEmpty()) {
-            dtc.add(resources.getString(R.string.pref_dtc_no_dtc_found))
-        }
+        val sortedDtcList = diagnosticTroubleCodes()
 
-        val adapter = DiagnosticTroubleCodeViewAdapter(context, dtc)
+        adapter = DiagnosticTroubleCodeViewAdapter(context)
+        adapter.submitList(sortedDtcList)
         val recyclerView: RecyclerView = root.findViewById(R.id.recycler_view)
         recyclerView.layoutManager = GridLayoutManager(context, 1)
         recyclerView.adapter = adapter
 
+        attachButtons(root, sortedDtcList)
         attachCloseButton(root)
+
         return root
     }
+
+    private fun attachButtons(
+        root: View,
+        sortedDtcList: List<DiagnosticTroubleCode>,
+    ) {
+        val refreshButton: Button = root.findViewById(R.id.action_refresh_dtc)
+        shareButton = root.findViewById(R.id.action_share)
+        clearButton = root.findViewById(R.id.action_clear_dtc)
+
+        shareButton.visibility = View.VISIBLE
+        clearButton.visibility = View.VISIBLE
+
+        if (isDtcAvailable(sortedDtcList)) {
+            shareButton.isEnabled = false
+            clearButton.isEnabled = false
+        }
+
+        shareButton.setOnClickListener {
+            shareDtcReport(sortedDtcList)
+        }
+
+        refreshButton.setOnClickListener {
+            if (DataLoggerRepository.isRunning()) {
+                withDataLogger {
+                    scheduleDTCRead()
+                }
+            } else {
+                toast(R.string.pref_dtc_no_connection_established)
+            }
+        }
+
+        clearButton.setOnClickListener {
+            android.app.AlertDialog
+                .Builder(requireContext())
+                .setTitle(resources.getString(R.string.pref_dtc_clean_dialog_title))
+                .setMessage(
+                    resources.getString(R.string.pref_dtc_clean_dialog_confirm_message),
+                ).setPositiveButton("Clear Codes") { dialog, _ ->
+                    if (DataLoggerRepository.isRunning()) {
+                        withDataLogger {
+                            scheduleDTCCleanup()
+                        }
+
+                        toast(R.string.pref_dtc_clean_dialog_send_message)
+                        clearButton.isEnabled = false
+                        clearButton.text = "Clearing..."
+                        dialog.dismiss()
+                    } else {
+                        toast(R.string.pref_dtc_no_connection_established)
+                    }
+                }.setNegativeButton("Cancel", null)
+                .show()
+        }
+    }
+
+    private fun shareDtcReport(dtcList: List<DiagnosticTroubleCode>) {
+        val reportBuilder = StringBuilder()
+        reportBuilder.append("Vehicle Diagnostic Report\n")
+        reportBuilder.append("-------------------------\n\n")
+
+        for (code in dtcList) {
+            if (code.standardCode.isEmpty()) continue
+
+            val formattedCode =
+                if (!code.failureType?.code.isNullOrEmpty()) {
+                    "${code.standardCode}-${code.failureType.code}"
+                } else {
+                    code.standardCode
+                }
+
+            reportBuilder.append("DTC: $formattedCode\n")
+            reportBuilder.append("Description: ${code.description ?: "Unknown"}\n")
+
+            val systemTxt = code.system?.description
+            val categoryTxt = code.category?.description
+            if (!systemTxt.isNullOrBlank() || !categoryTxt.isNullOrBlank()) {
+                reportBuilder.append("System: ${systemTxt ?: "N/A"} | Category: ${categoryTxt ?: "N/A"}\n")
+            }
+
+            val hex = code.rawHex ?: "N/A"
+            val activeStatuses = code.activeStatuses?.joinToString(", ") ?: "None"
+            reportBuilder.append("Status: $activeStatuses (Hex: $hex)\n")
+            reportBuilder.append("\n") // Blank line between codes
+        }
+
+        val sendIntent: Intent =
+            Intent().apply {
+                action = Intent.ACTION_SEND
+                putExtra(Intent.EXTRA_TEXT, reportBuilder.toString())
+                type = "text/plain"
+            }
+
+        val shareIntent = Intent.createChooser(sendIntent, "Share Diagnostic Report")
+        startActivity(shareIntent)
+    }
+
+    private fun diagnosticTroubleCodes(): List<DiagnosticTroubleCode> =
+        VehicleCapabilitiesManager
+            .getDiagnosticTroubleCodes()
+            .apply {
+                if (isEmpty()) {
+                    add(
+                        DiagnosticTroubleCode(
+                            "",
+                            "",
+                            null,
+                            resources.getString(R.string.pref_dtc_no_dtc_found),
+                            0,
+                            null,
+                            null,
+                            null,
+                            null,
+                            DtcComponent("", ""),
+                        ),
+                    )
+                }
+            }.sortedWith(
+                compareBy<DiagnosticTroubleCode> { code ->
+                    val desc = code.description
+                    val isUnknown =
+                        desc.isNullOrBlank() ||
+                            desc.contains(
+                                "Unknown DTC Description",
+                                ignoreCase = true,
+                            )
+                    if (isUnknown) 1 else 0
+                }.thenBy { code ->
+                    code.standardCode
+                },
+            ).toMutableList()
+
+    override fun onResume() {
+        super.onResume()
+        registerReceiver(requireContext(), dtcNotificationsReceiver) {
+            it.addAction(DATA_LOGGER_DTC_ACTION_COMPLETED)
+        }
+    }
+
+    override fun onPause() {
+        super.onPause()
+        requireContext().unregisterReceiver(dtcNotificationsReceiver)
+    }
+
+    private fun handleDTCChangedNotification() {
+        val newCodes = diagnosticTroubleCodes()
+        adapter.submitList(newCodes)
+
+        if (isDtcAvailable(newCodes)) {
+            shareButton.isEnabled = false
+            clearButton.isEnabled = false
+        } else {
+            shareButton.isEnabled = true
+            clearButton.isEnabled = true
+        }
+
+        clearButton.text = "Clear Codes"
+    }
+
+    private fun isDtcAvailable(newCodes: List<DiagnosticTroubleCode>): Boolean =
+        newCodes.size == 1 && newCodes.first().standardCode.isEmpty()
 }