fix: correct Dense input dim in BroNet and respect multiplier in SimbaBlock#23
Merged
typoverflow merged 2 commits intodev_categoricalfrom Feb 21, 2026
Merged
Conversation
Co-authored-by: typoverflow <41679605+typoverflow@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add BroNet, SimBa and categorical critic to networks
fix: correct Dense input dim in BroNet and respect multiplier in SimbaBlock
Feb 21, 2026
typoverflow
added a commit
that referenced
this pull request
Feb 21, 2026
* feat: add BroNet, simba and categorical critic * fix: correct Dense input dim in BroNet and respect multiplier in SimbaBlock (#23) * Initial plan * fix: correct Dense input dim in BroNet and use multiplier in SimbaBlock Co-authored-by: typoverflow <41679605+typoverflow@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: typoverflow <41679605+typoverflow@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: typoverflow <41679605+typoverflow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in the newly added
BroNetandSimbamodules that would cause runtime errors or silently ignore a user-configurable parameter.Fixes
bronet.py:nn.Dense(self.hidden_dims, ...)passed aSequence[int]where anintis required. Fixed tonn.Dense(self.hidden_dims[0], ...)— safe becausesetup()already asserts all dims are equal.simba.py:SimbaBlockhardcoded the expansion factor ashidden_dim * 4, making themultiplierfield on bothSimbaBlockandSimbaa no-op. Fixed tohidden_dim * self.multiplier.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.