feat: added xtasks fetch and code-gen to generate code#51
Merged
morenol merged 5 commits intotypesense:mainfrom Aug 27, 2025
Merged
feat: added xtasks fetch and code-gen to generate code#51morenol merged 5 commits intotypesense:mainfrom
fetch and code-gen to generate code#51morenol merged 5 commits intotypesense:mainfrom
Conversation
…pi spec Also added `compose.yml` to start a typesense server locally for testing
Contributor
Author
morenol
reviewed
Aug 27, 2025
Collaborator
morenol
left a comment
There was a problem hiding this comment.
LGTM, just small nit not sure if this should be run on CI and create a PR on intervals?
Contributor
Author
|
The tests should pass now.
Could be, but for now let's just run it manually. |
morenol
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
cargo xtask fetchwill fetch the api spec from this repository and overwrite theopenapi.yml.cargo xtask code-genwill preprocess theopenapi.ymland write it topreprocessed_openapi.ymlthen run the codegen via Docker.As to why we need to preprocess the open api spec file: some of the URL parameters are defined as object type (SearchParameters, MultisearchParameters,...) which are invalid. The preprocess step basically flatten the object into individual URL parameters.
Also added
compose.ymlto start a typesense server locally for future testing.PR Checklist