Skip to content

feat(library)!: infer version of actions/checkout in consistency check job from classpath by default #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krzema12 merged 4 commits into from
Jun 7, 2026
+10 −4
Merged

feat(library)!: infer version of actions/checkout in consistency check job from classpath by default #2337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9796ec2
feat(library)!: infer version of actions/checkout in consistency chec…
krzema12 Jun 7, 2026
b957256
Update tests
krzema12 Jun 7, 2026
b9b7412
Adjust failing test
krzema12 Jun 7, 2026
8af5337
Satisfy ktlint
krzema12 Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...dates-checker/src/test/kotlin/io/github/typesafegithub/workflows/updates/ReportingTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import io.github.typesafegithub.workflows.domain.actions.CustomAction
import io.github.typesafegithub.workflows.domain.triggers.Push
import io.github.typesafegithub.workflows.dsl.workflow
import io.github.typesafegithub.workflows.shared.internal.getGithubAuthTokenOrNull
import io.github.typesafegithub.workflows.yaml.CheckoutActionVersionSource
import io.github.typesafegithub.workflows.yaml.DEFAULT_CONSISTENCY_CHECK_JOB_CONFIG
import io.kotest.common.ExperimentalKotest
import io.kotest.core.spec.style.FunSpec
import io.kotest.engine.spec.tempdir
Expand Down Expand Up @@ -35,6 +37,10 @@ class ReportingTest :
name = "Test workflow",
on = listOf(Push()),
sourceFile = sourceTempFile,
consistencyCheckJobConfig =
DEFAULT_CONSISTENCY_CHECK_JOB_CONFIG.copy(
checkoutActionVersion = CheckoutActionVersionSource.Given("v4"),
),
useWorkflow = { output = function(it) },
) {
job(
Expand Down
2 changes: 1 addition & 1 deletion ...s-kt/src/main/kotlin/io/github/typesafegithub/workflows/yaml/ConsistencyCheckJobConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ public val DEFAULT_CONSISTENCY_CHECK_JOB_CONFIG: ConsistencyCheckJobConfig.Confi
ConsistencyCheckJobConfig.Configuration(
condition = null,
env = emptyMap(),
checkoutActionVersion = CheckoutActionVersionSource.BundledWithLibrary,
checkoutActionVersion = CheckoutActionVersionSource.InferFromClasspath(),
additionalSteps = null,
useLocalBindingsServerAsFallback = false,
)
Expand Down
6 changes: 3 additions & 3 deletions github-workflows-kt/src/test/kotlin/io/github/typesafegithub/workflows/IntegrationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class IntegrationTest :
steps:
- id: 'step-0'
name: 'Check out'
uses: 'actions/checkout@v6'
uses: 'actions/checkout@v4'
- id: 'step-1'
name: 'Execute script'
run: 'rm ''.github/workflows/some_workflow.yaml'' && ''.github/workflows/some_workflow.main.kts'''
Expand Down Expand Up @@ -282,7 +282,7 @@ class IntegrationTest :
steps:
- id: 'step-0'
name: 'Check out'
uses: 'actions/checkout@v6'
uses: 'actions/checkout@v4'
- id: 'step-1'
name: 'Execute script'
continue-on-error: true
Expand Down Expand Up @@ -722,7 +722,7 @@ class IntegrationTest :
steps:
- id: 'step-0'
name: 'Check out'
uses: 'actions/checkout@v6'
uses: 'actions/checkout@v4'
- id: 'step-1'
name: 'Execute script'
run: 'rm ''.github/workflows/some_workflow.yaml'' && ''.github/workflows/some_workflow.main.kts'''
Expand Down
Loading