fix: avoid NPE when a relative path is provided to Watcher::watch#3750
Merged
Conversation
Before this commit, `Watcher::watch` throws NPE when a path is relative path without a parent. This commit updates watchFile methods to defensively convert a path into absolute path and adds a test to confirm it won't throw NPE. It supersedes typelevel#3553 by SanjayUG
Contributor
Author
|
@mpilquist This is not urgent, but would you mind taking a look at this PR if you have a time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit,
Watcher::watchthrows NPE when a path is relative path without a parent.This commit updates watchFile methods to defensively convert a path into absolute path and adds a test to confirm it won't throw NPE.
It supersedes #3553 by SanjayUG