Bump lucide-svelte from 0.577.0 to 1.0.1#180
Merged
Merged
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/lucide-svelte-1.0.1
branch
from
6f39a01 to
2f0b86b
Compare
tylergraydev
added a commit
that referenced
this pull request
Apr 20, 2026
Roll up Dependabot patch/minor bumps (#181-#186, #188, #189): - Frontend: @tauri-apps/cli 2.10.0→2.10.1, @types/node 25.5.0→25.6.0, svelte-check 4.4.4→4.4.6 - Rust: tokio 1.50.0→1.52.1, rmcp 1.2.0→1.5.0, once_cell 1.21.3→1.21.4 (soundness fix), pulldown-cmark 0.13.1→0.13.3 (tar 0.4.45 security bump), env_logger 0.11.9→0.11.10 All 1996 Rust tests and 1564 frontend tests pass. TypeScript 6 (#187) and lucide-svelte 1.0 (#180) deferred to a separate migration effort — lucide 1.0 removed the Github brand icon used in 2 components. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
|
Deferred from v3.8.5 — lucide-svelte 1.0 removed the |
Owner
|
Reopening for a rebase — this PR is over a month stale, so the Rust/Clippy failures are just branch drift. The real signal is the one frontend test failure (Marketplace page header never renders), which looks like a genuine break from the lucide-svelte 1.x major (consistent with the Group D type drift tracked in #214). @dependabot rebase |
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/lucide-svelte-1.0.1
branch
from
2f0b86b to
b2cf5ad
Compare
Bumps [lucide-svelte](https://github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-svelte) from 0.577.0 to 1.0.1. - [Release notes](https://github.com/lucide-icons/lucide/releases) - [Commits](https://github.com/lucide-icons/lucide/commits/1.0.1/packages/lucide-svelte) --- updated-dependencies: - dependency-name: lucide-svelte dependency-version: 1.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
tylergraydev
force-pushed
the
dependabot/npm_and_yarn/lucide-svelte-1.0.1
branch
from
b2cf5ad to
875b4ca
Compare
Owner
|
Rebased onto current main (was very stale, ~2 months behind) and added a follow-up commit to fix the breakage the bare bump caused. Two issues this bump introduced
Fix on top of the bump
Verification
🤖 Generated with Claude Code |
…214 Group D ## What was wrong Two separate problems blocked this dependabot bump: 1. **Github icon removed from lucide.** lucide v1.0 dropped many brand icons (Github, Discord, etc.) for trademark reasons. The bare bump produced two `[MISSING_EXPORT]` build failures in marketplace and settings cloud-sync tab. 2. **#214 Group D — 7 TS errors on icon props.** Existing errors on `ActionMenuItem` / `EmptyState` `icon={SomeIcon}` call sites in `ProjectCard`, `ProjectList`, `McpLibrary`. Both consumers typed the prop as Svelte 5's `Component<any>`, which lucide-svelte 1.x doesn't satisfy: it still exports icons as the legacy `SvelteComponentTyped` class shape (renders fine at runtime, but TS treats `typeof RefreshCw` as incompatible with `Component<...>`). Pre-existing in main since #210/lucide major bumps. ## Fix - Inlined a `GithubIcon.svelte` component using lucide's original stroke-style Github SVG path so the visual is identical to what we had pre-upgrade. Props mirror lucide's shape (`class`, `size`, `color`, `strokeWidth`) so call sites stay one-liners. Replaced the 4 `<Github ...>` usages in `marketplace/+page.svelte` and `SettingsCloudSyncTab.svelte` with `<GithubIcon ...>`. - Loosened `icon` prop type in `ActionMenuItem` and `EmptyState` via a documented `IconLike = any` alias. Comment explains why (lucide uses legacy SvelteComponentTyped — accepting both shapes via a union would be uglier and gain little). This is the canonical resolution for #214 Group D — also closes the 7 errors when the bump lands. ## Verification - `npm run check` — **11 errors** (down from 18 on `main`; closes all 7 Group D errors) - `npm run build` — succeeds - `npx vitest run` — 1567/1567 pass ## Net file changes - `package.json` / `package-lock.json` — lucide-svelte 0.577 -> 1.0.1 - `src/lib/components/shared/GithubIcon.svelte` (new, ~40 lines) - `src/lib/components/shared/ActionMenuItem.svelte` — icon type - `src/lib/components/shared/EmptyState.svelte` — icon type - `src/lib/components/settings/tabs/SettingsCloudSyncTab.svelte` — import swap - `src/routes/marketplace/+page.svelte` — import swap Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
tylergraydev
force-pushed
the
dependabot/npm_and_yarn/lucide-svelte-1.0.1
branch
from
875b4ca to
1f657bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps lucide-svelte from 0.577.0 to 1.0.1.
Release notes
Sourced from lucide-svelte's releases.
... (truncated)
Commits
484f2c9docs(version-1): Version 1 website (#4142)a0e202dfeat(packages/angular): add new@lucide/angularpackage (#3897)4d44278docs(svelte): clarify Svelte 4 vs Svelte 5 Lucide packages (#4107)