This repository was archived by the owner on Apr 24, 2023. It is now read-only.
Make the user cache work for job entities in the queue.#2074
Open
scrosby wants to merge 12 commits intotwosigma:masterfrom
Open
Make the user cache work for job entities in the queue.#2074scrosby wants to merge 12 commits intotwosigma:masterfrom
scrosby wants to merge 12 commits intotwosigma:masterfrom
Conversation
added 12 commits
May 31, 2022 13:40
task-ent->user uses :db/id as a cache key. However, synthetic tasks entities for pending jobs don't have that and aren't cached. This makes that cache essentially noop for pending jobs; they always miss. Fix this by borrowing the :db/id of the source job.
scrosby
force-pushed
the
outgoing/fix-job-user-cache
branch
from
f099b31 to
baf99b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
Why are we making these changes?
task-ent->user uses :db/id as a cache key. However, synthetic tasks
entities for pending jobs don't have that and aren't cached. This makes
that cache essentially noop for pending jobs; they always miss.
Fix this by borrowing the :db/id of the source job.