Add documention note about variable scope of override blocks in {% embed ... only %}#4845
Open
andy-blum wants to merge 2 commits into
Open
Add documention note about variable scope of override blocks in {% embed ... only %}#4845andy-blum wants to merge 2 commits into
andy-blum wants to merge 2 commits into
Conversation
e0ipso
reviewed
Jun 17, 2026
Comment on lines
+181
to
+182
| {# "name" is undefined inside the block #} | ||
| {% embed "base" only %} |
There was a problem hiding this comment.
Suggested change
| {# "name" is undefined inside the block #} | |
| {% embed "base" only %} | |
| {% embed "base" only %} | |
| {# "name" is undefined inside the block #} |
e0ipso
reviewed
Jun 17, 2026
Comment on lines
+186
to
+187
| {# "name" is passed explicitly and is available #} | ||
| {% embed "base" with {'name': name} only %} |
There was a problem hiding this comment.
Suggested change
| {# "name" is passed explicitly and is available #} | |
| {% embed "base" with {'name': name} only %} | |
| {% embed "base" with {'name': name} only %} | |
| {# "name" is passed explicitly and is available #} |
e0ipso
reviewed
Jun 17, 2026
e0ipso
left a comment
e0ipso
left a comment
There was a problem hiding this comment.
Good clarifications. I suggested an über-nit pick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4844